Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raleigh-Class Mercenary Corvette #3458

Merged
merged 37 commits into from
Oct 24, 2024
Merged

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Sep 29, 2024

About The Pull Request

StrongDMM-2024-10-06 19 02 02
StrongDMM-2024-10-06 19 02 03

dreamseeker_qhkyYgbpdx
dreamseeker_8jf3u0ZlwA
dreamseeker_jJx71tKdzb

Adds the Raleigh Class Corvette - a century old design manufactured by Kasagi-Fischer for yuppie solarians, and now retooled for usage as a mercenary vessel.

Originally sold as a 'Safari Ship', or a 'Yacht' in some markets, the strange shape and relative quality of the design made it very appealing for usage by unaligned mercenaries forces, with the vessel capable of carrying a small complement of supposedly professional soldiers.

The Raleigh supports a crew of:
1 - Captain
1 - Lieutenant
1 - Engineer
3 - Troopers
1 - Recruit (random guy we found)

The Raleigh's gear includes:
1 - E40
1 - Cobra-20
2 - Ringnecks
Assorted Machetes
The Yuri Room
The Gambling Room
The Emergency Medical Hologram

Why It's Good For The Game

Adds a combat/rp focused ship for mercenaries that's |not| inteq. Think of all the possibilities.

Changelog

🆑
add: Kasagi-Fischer has begun a new production run of the venerable Raleigh-class Corvette. See your purchaser's manual for more information!
/:cl:

@Erikafox Erikafox requested a review from a team as a code owner September 29, 2024 18:24
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Code change Watch something violently break. labels Sep 29, 2024
@Apogee-dev
Copy link
Contributor

Apogee-dev commented Sep 29, 2024

I feel like the XO could use a different job title that feels a little less professional and a little more mercenary, and that leans more into a “lead the squad” type of playstyle than a “sit on the ship” style. Lieutenant might actually fit the bill here- it’s pretty frequently used to refer to a second-in-command or other lower “officer” of a gang, merc company, or paramilitary in real life.

Also, can you include a screenshot of the outfits, since most of them are new?

@github-actions github-actions bot removed the DME Edit label Sep 29, 2024
@Erikafox
Copy link
Contributor Author

dreamseeker_dxpPGoMlY0

There you go

@meemofcourse
Copy link
Contributor

now we will have inteq mercenaries AND indie mercenaries. genius

@Erikafox
Copy link
Contributor Author

im thinking about adding syndicate mercenaries next

@Erikafox
Copy link
Contributor Author

Erikafox commented Oct 1, 2024

done

@Erikafox Erikafox requested a review from a team as a code owner October 1, 2024 22:28
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. labels Oct 1, 2024
@meemofcourse
Copy link
Contributor

dude this is just like michael brown

@FalloutFalcon FalloutFalcon added the Ship Ship successfully tested. label Oct 5, 2024
Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback after testing on live:

There's still two small cash spawners in the LT's and captain's office. Replace those with pocket cash spawners as well please.

Add a weapon power cell to the armory, so the powercell on the e-40 can be swapped out if needed.

The ship has only one EVA suit. I'd suggest adding two more suits, so the troopers have enough suits to head out together.

Players testing the Raleigh noted while playing the ship the cargo bay felt cramped. I think taking this dividing wall and door here and making it into one room could help alleviate it. Try it out and see how you feel about it.
image

Also please remove the Hammer from the armory for now, since it's apparently crashing the server?

nevermind, turns out it was gibbing killing the server

@DrCrawler
Copy link
Contributor

The ship has no viewscreens, which is pretty sad.

@Apogee-dev Apogee-dev added the Test Merge Required They'll have to do it for free. label Oct 7, 2024
@Gristlebee Gristlebee added this pull request to the merge queue Oct 23, 2024
Merged via the queue into shiptest-ss13:master with commit 0bf287a Oct 24, 2024
14 checks passed
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
![StrongDMM-2024-10-06 19 02
02](https://github.com/user-attachments/assets/f44a57a7-ef44-4696-8c08-c00a2ba63367)
![StrongDMM-2024-10-06 19 02
03](https://github.com/user-attachments/assets/4b862d9e-13b7-486f-83ca-c5de470dc7ca)


![dreamseeker_qhkyYgbpdx](https://github.com/user-attachments/assets/2f4dd01a-527e-4e9f-bd70-ec9ad8653d73)

![dreamseeker_8jf3u0ZlwA](https://github.com/user-attachments/assets/d7e3b7ac-1e96-4b32-b3bc-a6e213c648db)

![dreamseeker_jJx71tKdzb](https://github.com/user-attachments/assets/16b5a426-d622-4059-926c-151ce0a41e61)

Adds the Raleigh Class Corvette - a century old design manufactured by
Kasagi-Fischer for yuppie solarians, and now retooled for usage as a
mercenary vessel.

Originally sold as a 'Safari Ship', or a 'Yacht' in some markets, the
strange shape and relative quality of the design made it very appealing
for usage by unaligned mercenaries forces, with the vessel capable of
carrying a small complement of supposedly professional soldiers.

The Raleigh supports a crew of:
1 - Captain
1 - Lieutenant
1 - Engineer
3 - Troopers
1 - Recruit (random guy we found)

The Raleigh's gear includes:
1 - E40
1 - Cobra-20
2 - Ringnecks
Assorted Machetes
The Yuri Room
The Gambling Room
The Emergency Medical Hologram


<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

Adds a combat/rp focused ship for mercenaries that's |not| inteq. Think
of all the possibilities.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Kasagi-Fischer has begun a new production run of the venerable
Raleigh-class Corvette. See your purchaser's manual for more
information!
/:cl:
<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Erika Fox <[email protected]>
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested. Sprites A bikeshed full of soulless bikes. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants