Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TGUI pipe dispenser #3464

Merged

Conversation

Thera-Pissed
Copy link
Contributor

@Thera-Pissed Thera-Pissed commented Oct 2, 2024

About The Pull Request

Implements a tweaked UI from rapid pipe dispensers for normal (obj/machinery/pipedispenser) dispensers
Pipe dispensers now have a 5ms delay on prints and can make disposals and transport tubes.
Removes dispenser/disposals and dispenser/transport because they're redundant now.
image

updates text2path regex to 115 from 117
updates non-bitwise << uses to 262 from 266

Why It's Good For The Game

The old UI sucks and is laggy and bad.

Changelog

🆑
add: pipe dispenser UI is now similar to rapid pipe dispenser UI.
/:cl:

retools the pipe dispenser to work and have a UI based off of the rapid pipe dispenser. pipe dispensers have a 5ms delay on prints and can make disposals and transport tubes now.
@github-actions github-actions bot added TGUI Code change Watch something violently break. labels Oct 2, 2024
@Thera-Pissed Thera-Pissed requested a review from a team as a code owner October 2, 2024 02:46
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Oct 2, 2024
@Orchidthederg
Copy link
Contributor

FINALLY!! I'M FREE FROM THIS CURSE!!!

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Oct 4, 2024
Merged via the queue into shiptest-ss13:master with commit f3fd10a Oct 4, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Oct 6, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Implements a tweaked UI from rapid pipe dispensers for normal
(obj/machinery/pipedispenser) dispensers
Pipe dispensers now have a 5ms delay on prints and can make disposals
and transport tubes.
Removes dispenser/disposals and dispenser/transport because they're
redundant now.

![image](https://github.com/user-attachments/assets/73a9bd7a-7d5d-49d2-a8f2-3313350ee4c8)

updates text2path regex to 115 from 117
updates non-bitwise << uses to 262 from 266
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
The old UI sucks and is laggy and bad.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: pipe dispenser UI is now similar to rapid pipe dispenser UI.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: FalloutFalcon <[email protected]>
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 24, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Implements a tweaked UI from rapid pipe dispensers for normal
(obj/machinery/pipedispenser) dispensers
Pipe dispensers now have a 5ms delay on prints and can make disposals
and transport tubes.
Removes dispenser/disposals and dispenser/transport because they're
redundant now.

![image](https://github.com/user-attachments/assets/73a9bd7a-7d5d-49d2-a8f2-3313350ee4c8)

updates text2path regex to 115 from 117
updates non-bitwise << uses to 262 from 266
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
The old UI sucks and is laggy and bad.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: pipe dispenser UI is now similar to rapid pipe dispenser UI.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: FalloutFalcon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. TGUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants