Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give IPCs some more adjectives to work with and cleans up duplicate adjectives. #3475

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

DrCrawler
Copy link
Contributor

@DrCrawler DrCrawler commented Oct 3, 2024

About The Pull Request

Adds the adjectives that can also be applied to IPCs from the main adjective list to the IPC adjective list.

Why It's Good For The Game

Lets players pick a more fitting adjective for their character, removes arbitrariness and duplicate adjectives.

Changelog

🆑
add: Gives IPCs a little more adjectives to work with.
del: Removed some duplicate adjectives from the raw file.
/:cl:

@DrCrawler
Copy link
Contributor Author

Does the ship placement check always do that..?

@Erikafox
Copy link
Contributor

Erikafox commented Oct 3, 2024

basically

@thgvr
Copy link
Member

thgvr commented Oct 3, 2024

almost always unfortunately

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Oct 7, 2024
Merged via the queue into shiptest-ss13:master with commit 603d242 Oct 7, 2024
14 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
…djectives. (shiptest-ss13#3475)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Adds the adjectives that can also be applied to IPCs from the main
adjective list to the IPC adjective list.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Lets players pick a more fitting adjective for their character, removes
arbitrariness and duplicate adjectives.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Gives IPCs a little more adjectives to work with.
del: Removed some duplicate adjectives from the raw file.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants