Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflavors the Li Tieguai-class. #3485

Merged
merged 22 commits into from
Nov 3, 2024
Merged

Conversation

Sadhorizon
Copy link
Contributor

@Sadhorizon Sadhorizon commented Oct 6, 2024

About The Pull Request

Li Tieg is now more similar to #3323 style-wise, with the difference that it's in Biodynamics teal instead of fully in VS red.

Screenshots:

scrnshot1

StrongDMM-2024-10-17 21 02 51

StrongDMM-2024-10-06 23 02 48

Also tweaks Li Tieg's weaponry:

  • Trauma team looses one Ringneck, but gains a Rattlesnake. - Rattlesnake is just cool.
  • Captain looses the Viper. It's replaced by a Himehabu and an edagger. - A Himehabu fits CS caps waaaay better than a Viper. Edagger is also CS special.
  • Director looses the Ringneck and the Dart Gun. They only get an edagger now. Sorry. - I'd say they really don't need a gun. Edagger is cool though.

Why It's Good For The Game

Please stop with the carpets and curtains. I beg you.

Changelog

🆑
tweak: Reflavored Li Tieguai-class to use Cybersun Biodynamics colors.
balance: Removed the Viper, the Dart Gun and two Ringnecks from the Li Tieguai. Instead, added a Rattlesnake, a Himehabu and two edaggers.
fix: Li Tieguai captain is now an officer.
/:cl:

@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Oct 6, 2024
@generalthrax
Copy link
Contributor

generalthrax commented Oct 6, 2024

I've captained the Li Tieguai a lot. Possibly more than anyone else. There is one major issue (to me) that this could fix

image

The armoury being in the dorms always felt really weird. Felt like it could be swapped places with the bathroom to be in the Trauma Team prep room instead, up here.

image

@Apogee-dev
Copy link
Contributor

Apogee-dev commented Oct 7, 2024

Oh right, please put the guns in pistol cases. They shouldn’t be spawning loose unless they’re in a gun rack or display case or something like that- iirc we were moving towards using those cases even in job equipment lockers like we see here.

@Sadhorizon
Copy link
Contributor Author

The armoury being in the dorms always felt really weird. Felt like it could be swapped places with the bathroom to be in the Trauma Team prep room instead, up here.

I feel like it would either make the bathroom hyper squished (bad), or make it cut into dorms (also bad).

I agree that it sucks but I really don't want to fix the layout in here, as, let's be real, most of it sucks.

@github-actions github-actions bot requested a review from FalloutFalcon October 7, 2024 14:10
@Sadhorizon Sadhorizon marked this pull request as ready for review October 7, 2024 14:12
@Sadhorizon Sadhorizon requested a review from a team as a code owner October 7, 2024 14:12
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 24, 2024
@github-actions github-actions bot added Ship Ship successfully tested. and removed Merge Conflict Use Git Hooks, you're welcome. labels Oct 25, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 26, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 26, 2024
@thgvr thgvr added this pull request to the merge queue Nov 3, 2024
Merged via the queue into shiptest-ss13:master with commit f1e1a80 Nov 3, 2024
16 checks passed
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Li Tieg is now more similar to shiptest-ss13#3323 style-wise, with the difference
that it's in Biodynamics teal instead of fully in VS red.

<details><summary>Screenshots:</summary>
<p>


![scrnshot1](https://github.com/user-attachments/assets/335a85a0-12e2-44ad-af38-d09f5d627396)

![StrongDMM-2024-10-17 21 02
51](https://github.com/user-attachments/assets/a57ed1da-4f3b-4684-a263-d8d2f92def42)

![StrongDMM-2024-10-06 23 02
48](https://github.com/user-attachments/assets/94d32a52-614a-4fc0-856f-bca24d952be9)

</p>
</details> 

Also tweaks Li Tieg's weaponry:
- Trauma team looses one Ringneck, but gains a Rattlesnake. -
Rattlesnake is just cool.
- Captain looses the Viper. It's replaced by a Himehabu and an edagger.
- A Himehabu fits CS caps waaaay better than a Viper. Edagger is also CS
special.
- Director looses the Ringneck and the Dart Gun. They only get an
edagger now. Sorry. - I'd say they really don't need a gun. Edagger is
cool though.

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Please stop with the carpets and curtains. I beg you.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Reflavored Li Tieguai-class to use Cybersun Biodynamics colors.
balance: Removed the Viper, the Dart Gun and two Ringnecks from the Li
Tieguai. Instead, added a Rattlesnake, a Himehabu and two edaggers.
fix: Li Tieguai captain is now an officer.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Ship Ship successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants