Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Ration Heaters smaller. #3486

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

Aquidu
Copy link
Contributor

@Aquidu Aquidu commented Oct 6, 2024

About The Pull Request

Edits ration heaters to be able to be put back inside of ration packs.

Why It's Good For The Game

It's really, really annoying that you can take ration heaters OUT of ration packs, but CANNOT put them back in. This fixes this by making them both the same size as the rations themselves, and adding ration heaters to the list of accepted items that can be put in ration packs.

Changelog

🆑
code: Changes flameless ration heaters to "small" items
code: Adds flameless ration heaters to the ration pack item whitelist.
/:cl:

@Aquidu Aquidu requested a review from FalloutFalcon as a code owner October 6, 2024 22:48
@github-actions github-actions bot added the Code change Watch something violently break. label Oct 6, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea this was an oversight i never got around to fixing! Good pr!

@FalloutFalcon FalloutFalcon added this pull request to the merge queue Oct 6, 2024
Merged via the queue into shiptest-ss13:master with commit df5118d Oct 6, 2024
14 checks passed
@Aquidu Aquidu deleted the smaller-ration-heater branch October 9, 2024 10:20
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request Oct 21, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

Edits ration heaters to be able to be put back inside of ration packs.

It's really, really annoying that you can take ration heaters OUT of
ration packs, but CANNOT put them back in. This fixes this by making
them both the same size as the rations themselves, and adding ration
heaters to the list of accepted items that can be put in ration packs.

:cl:
code: Changes flameless ration heaters to "small" items
code: Adds flameless ration heaters to the ration pack item whitelist.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants