Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defines the two primary atmos req types #3490

Merged
merged 6 commits into from
Oct 19, 2024

Conversation

FalloutFalcon
Copy link
Member

About The Pull Request

Makes two defines for atmos requirments, immune and normal, as they are 99% of atmos requirments

Why It's Good For The Game

i hate looking at it to be frank
saves atleast one byte of space

Changelog

🆑
code: makes defines for the two primary atoms requirement lists
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Oct 7, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@FalloutFalcon FalloutFalcon requested review from a team as code owners October 15, 2024 13:24
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Sprites A bikeshed full of soulless bikes. and removed Merge Conflict Use Git Hooks, you're welcome. labels Oct 15, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 15, 2024
@github-actions github-actions bot removed Merge Conflict Use Git Hooks, you're welcome. Map Change Tile placing is hard. Thank you for your service. DME Edit Sprites A bikeshed full of soulless bikes. labels Oct 15, 2024
@FalloutFalcon FalloutFalcon added the Test Merged They've done it for free. label Oct 16, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 16, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict Use Git Hooks, you're welcome. and removed Merge Conflict Use Git Hooks, you're welcome. labels Oct 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 18, 2024
Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah

@Sun-Soaked Sun-Soaked added this pull request to the merge queue Oct 19, 2024
Merged via the queue into shiptest-ss13:master with commit 813cf06 Oct 19, 2024
14 checks passed
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Makes two defines for atmos requirments, immune and normal, as they are
99% of atmos requirments
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
i hate looking at it to be frank
saves atleast one byte of space
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
code: makes defines for the two primary atoms requirement lists
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Sun-Soaked <[email protected]>
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants