Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors lootdroppers #3526

Merged
merged 36 commits into from
Oct 24, 2024
Merged

Conversation

FalloutFalcon
Copy link
Member

@FalloutFalcon FalloutFalcon commented Oct 10, 2024

About The Pull Request

Refactors lootdroppers, giving them a fresh coat of paint from tgstation/tgstation#60522
Ports docking port sprites from tgstation/tgstation#82729
I also tweaked some of the mapping helper's icons.

Why It's Good For The Game

Changelog

🆑
refactor: refactored some mapping stuff including random spawners!
/:cl:

@FalloutFalcon FalloutFalcon requested review from MarkSuckerberg and a team as code owners October 10, 2024 21:49
@FalloutFalcon FalloutFalcon changed the title Netur my wenior Refactors lootdroppers Oct 10, 2024
@github-actions github-actions bot added Config Watch us shake head admins violently until this gets merged. Map Change Tile placing is hard. Thank you for your service. DME Edit labels Oct 10, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 17, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 17, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 18, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 18, 2024
@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 22, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Ship Ship successfully tested. Ruin Ruin successfully tested. labels Oct 24, 2024
@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 24, 2024
Copy link
Member

@Sun-Soaked Sun-Soaked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another pr sterilized

@Sun-Soaked Sun-Soaked added this pull request to the merge queue Oct 24, 2024
Merged via the queue into shiptest-ss13:master with commit 94cb62b Oct 24, 2024
15 checks passed
generalthrax added a commit to generalthrax/Shiptest that referenced this pull request Oct 26, 2024
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Refactors lootdroppers, giving them a fresh coat of paint from
tgstation/tgstation#60522
Ports docking port sprites from
tgstation/tgstation#82729
I also tweaked some of the mapping helper's icons.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
refactor: refactored some mapping stuff including random spawners!
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
zimon9 pushed a commit to zimon9/Shiptest-PR-testing that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Config Watch us shake head admins violently until this gets merged. DME Edit Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Ship Ship successfully tested. Sprites A bikeshed full of soulless bikes. Test Merged They've done it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants