Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outpost Vendors Cost Money #3529

Merged

Conversation

Erikafox
Copy link
Contributor

@Erikafox Erikafox commented Oct 11, 2024

About The Pull Request

Outpost vendors now cost some money (instead of selling everything for free)
also ports tgstation/tgstation#54463

Why It's Good For The Game

The economy is in shambles

Changelog

🆑
balance: Outpost vending machines now cost money.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label Oct 11, 2024
@Sadhorizon
Copy link
Contributor

Sadhorizon commented Oct 11, 2024

Issue here is that prices are balanced around stations.
I think it all should be made very cheap, as more of a symbolic price than anything. The likes of 10 credits per item maybe. So the outpost doesn't give stuff for free, but also, you can still buy all you really need with the roundstart 150.

Also, make sure it actually works. I tried this before and I couldn't actually buy stuff, probably because of bank cards.

@Erikafox
Copy link
Contributor Author

yeah i made it work and also changed prices across the board. balance is pulled completely out of my ass.

Comment on lines +196 to +197
if(istype(get_area(src.loc), /area/outpost) || istype(get_area(src.loc), /area/ruin))
all_items_free = FALSE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would make more sense as a !ship_area but this is also fine.

Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was me I would also let you hack them to turn the prices on and off.

@Erikafox
Copy link
Contributor Author

If it was me I would also let you hack them to turn the prices on and off.

I feel like that's a way to completely circumvent what im doing with this

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Oct 28, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Oct 28, 2024
@Sun-Soaked Sun-Soaked added this pull request to the merge queue Nov 2, 2024
Merged via the queue into shiptest-ss13:master with commit 76958b0 Nov 2, 2024
16 checks passed
@Anticept
Copy link
Contributor

Anticept commented Nov 6, 2024

This PR seems to have made ALL vendors cost money, including ones found as loot.

This is a bit odd for places like the singulo lab for example, where the engineering vendors are charging money...

@Erikafox
Copy link
Contributor Author

Erikafox commented Nov 7, 2024

image

@Anticept
Copy link
Contributor

Anticept commented Nov 7, 2024

I saw it. That makes this PR's title and its changelog incomplete and misleading since it only says outpost but is being applied to ruins too, which is odd for some vendors, and in a roundabout way, is changing loot available in ruins.

@tantspants
Copy link

tantspants commented Nov 7, 2024

prices are totally ridiculous. 100 cr for lime juice? It should be 1/10 that.

@Erikafox
Copy link
Contributor Author

Erikafox commented Nov 7, 2024

make a pr to reduce prices?

@Erikafox Erikafox deleted the outpost-vendors-cost-money branch November 7, 2024 01:24
MrCat15352 pushed a commit to MrCat15352/MrCat that referenced this pull request Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->
Outpost vendors now cost some money (instead of selling everything for
free)
also ports tgstation/tgstation#54463

<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->
The economy is in shambles
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

:cl:
balance: Outpost vending machines now cost money.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Signed-off-by: Erika Fox <[email protected]>
Co-authored-by: Erika Fox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants