Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rock Ruin: N+S Mining Installation #3534

Merged
merged 41 commits into from
Nov 15, 2024

Conversation

Erikafox
Copy link
Contributor

About The Pull Request

Pictures

dreamseeker_xEj59EPTs5
dreamseeker_auitVwi8CV
dreamseeker_scQzFBzfAx
StrongDMM-2024-10-11 15 15 44
StrongDMM-2024-10-11 15 15 45

Adds a new ruin to the rockplanet pool. The N+S Mining Base is a small mining installation that had been built to extract minerals - and then was promptly raided by the Ramzi Clique (ramzi guys are somewhat waiting on #3462. I consider them placeholder right now). The ruin contains a small amount of weaponry, some fluff, and a refinery for your lovely ore mining efforts.

The main gimmick is based around cleaning the base up, getting it somewhat functional, and using the drill to extract ore from the comically good ore veins. There are platforms with turrets deployed around them (as well as sandbags) to form a defensible position, but unless you can get into the refinery, it'll be somewhat annoying to actually use.

Why It's Good For The Game

It's gimmicky content!!

Changelog

🆑
add: N+S has reported losing contact with one of their rockplanet based mining installations
/:cl:

@Erikafox Erikafox requested a review from a team as a code owner October 11, 2024 19:30
@github-actions github-actions bot added the Map Change Tile placing is hard. Thank you for your service. label Oct 11, 2024
@github-actions github-actions bot added Ruin Ruin successfully tested. and removed Merge Conflict Use Git Hooks, you're welcome. labels Nov 8, 2024
@Gristlebee Gristlebee added Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free. labels Nov 8, 2024
Copy link
Contributor

@Gristlebee Gristlebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback after testing on live:

  • Some of the platforms overlay weirdly when there's stuff on the same tiles.
    image
    image

  • The heater isnt properly linked to distro
    image

  • The outside hades on the walkway is pretty close to the other one in the sec office, and relatively easy to grab. Swap it out for a different weapon, or move it into another one of the buildings. Maybe the dorms or the manager's office as a suggestion since they're lacking in things to grab.

@Erikafox
Copy link
Contributor Author

yeag. aware of the overlays. one of the hades should be removed - but if you'd like i can put an energy weapon in the manager's office.
will fix heater eventually

@Gristlebee
Copy link
Contributor

yeag. aware of the overlays. one of the hades should be removed - but if you'd like i can put an energy weapon in the manager's office. will fix heater eventually

Sounds good to me.

@Gristlebee
Copy link
Contributor

Gristlebee commented Nov 15, 2024

Changes look good.

Move the Hades inside the building, and take one of the eguns inside and put it under the miner corpse instead. It's a major loot item and shouldn't be outside I feel.

image

Once that's done, I'll see about getting this merged.

@Gristlebee Gristlebee added this pull request to the merge queue Nov 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 15, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
<details><summary>Pictures</summary>
<p>


![dreamseeker_xEj59EPTs5](https://github.com/user-attachments/assets/d92a9fb4-818e-465e-96f0-99a93798eca6)

![dreamseeker_auitVwi8CV](https://github.com/user-attachments/assets/6638cb59-d77f-4000-b6b0-490ba4eeb0b1)

![dreamseeker_scQzFBzfAx](https://github.com/user-attachments/assets/744de12a-4943-458a-87d6-a4f6be7e7e36)
![StrongDMM-2024-10-11 15 15
44](https://github.com/user-attachments/assets/5ba2a741-60c0-4988-9740-fdafcaa14586)
![StrongDMM-2024-10-11 15 15
45](https://github.com/user-attachments/assets/47b5fffd-9faf-41c5-8e99-ac3016ea8f6a)

</p>
</details> 


Adds a new ruin to the rockplanet pool. The N+S Mining Base is a small
mining installation that had been built to extract minerals - and then
was promptly raided by the Ramzi Clique (ramzi guys are somewhat waiting
on #3462. I consider them placeholder right now). The ruin contains a
small amount of weaponry, some fluff, and a refinery for your lovely ore
mining efforts.

The main gimmick is based around cleaning the base up, getting it
somewhat functional, and using the drill to extract ore from the
comically good ore veins. There are platforms with turrets deployed
around them (as well as sandbags) to form a defensible position, but
unless you can get into the refinery, it'll be somewhat annoying to
actually use.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
It's gimmicky content!!
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: N+S has reported losing contact with one of their rockplanet based
mining installations
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: Erika Fox <[email protected]>
@Gristlebee Gristlebee removed this pull request from the merge queue due to a manual request Nov 15, 2024
@goober3 goober3 added this pull request to the merge queue Nov 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 15, 2024
@Gristlebee Gristlebee added this pull request to the merge queue Nov 15, 2024
@Gristlebee
Copy link
Contributor

aw dangit

Merged via the queue into shiptest-ss13:master with commit 5c8c21c Nov 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested. Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants