Removes some cruft from sheet construction - mainly, job statues. #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
|
i think karl deserves to stay |
|
communism can be shown in ways other than 5+ century long dead figures |
shiptest-server
pushed a commit
that referenced
this pull request
Oct 15, 2024
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
…iptest-ss13#3539) <!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Removes: - cardborg suit - It feels like it doesn't *exactly* fit the setting. Can revert though. - Karl Marx bust. - all the job statues - the jobs no longer exist in the same sense as before - human/gondola/monkey skinsuits - I don't imagine parading in monkey masks as fitting the setting I'm actually removing all the statues listed above completely from the code. <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game That's the man alright.  <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: del: Removed Karl Marx from the game. del: Removed all the job statues. del: Cardborg suit, human, gondola and monkey skinsuits are no longer craftable. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Removes:
I'm actually removing all the statues listed above completely from the code.
Why It's Good For The Game
That's the man alright.
Changelog
🆑
del: Removed Karl Marx from the game.
del: Removed all the job statues.
del: Cardborg suit, human, gondola and monkey skinsuits are no longer craftable.
/:cl: