Fixed the CLIP War Correspondent sprite for Vox #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rye-rice
approved these changes
Oct 12, 2024
A quick look through the history later - The vox variation (and the whole helmet, I believe) were added here: 3925680#diff-72e26b7f3303ce835ef698eaf4fe36ea28ee1423e714f73c501b714042f79ab5 Nothing removed it, it seems like it simply needed ' supports_variations = VOX_VARIATION ' to work properly, and that was never added. The sprite was in, it was simply never used. |
|
What's weird is that not only do I distinctly remember it's sprite showing up in-game, I have screenshots. On the first Atlas round ever. |
shiptest-server
pushed a commit
that referenced
this pull request
Oct 14, 2024
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
## About The Pull Request This helmet has a Vox sprite available that used to work (but doesn't anymore for some reason), this PR makes it correctly show up now. ## Why It's Good For The Game Fixes species support for an item that should have it. ## Changelog :cl: fix: War Correspondent helmet has a proper sprite for Vox. /:cl:
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This helmet has a Vox sprite available that used to work (but doesn't anymore for some reason), this PR makes it correctly show up now.
Why It's Good For The Game
Fixes species support for an item that should have it.
Changelog
🆑
fix: War Correspondent helmet has a proper sprite for Vox.
/:cl: