Console examine_more viewability change #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g for bluetooth activation with ones mind
FalloutFalcon
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
I like this, one change i might make is only having this work within a view tiles. Its fine for the bigger screens but you really shouldn't be able to read a laptop from a full screen width.
just needs test merges to ensure it works as intended.
I haven't looked at the code for a while and coulda sworn these would normally auto-close.
Ah, it already behaves this way. Example: dreamseeker_J9xWFYVohQ.mp4It also auto-closes when you move sufficiently far away, in this case being two tiles away. |
shiptest-server
pushed a commit
that referenced
this pull request
Oct 26, 2024
zimon9
added a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This PR makes it so that you can view a console, laptop, a wideband log, the screen on an APC, and the gasses measured from an air alarm, from one tile away. You can not interact with the UI unless you are right next to it. To do this, the examine_more function is used. ## Why It's Good For The Game It makes sense to be able to see screens without having to be right next to them. You will still be unable to interact with them, but you no longer need to be right next to them just to open up the UI. Laptops have also always required holding them in your hands to open up the UI, and this change should address that so that this is no longer necessary. ## Changelog :cl: add: Added ability to see screens using the examine_more function /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
zimon9
pushed a commit
to zimon9/Shiptest-PR-testing
that referenced
this pull request
Oct 29, 2024
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Dec 27, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request This PR makes it so that you can view a console, laptop, a wideband log, the screen on an APC, and the gasses measured from an air alarm, from one tile away. You can not interact with the UI unless you are right next to it. To do this, the examine_more function is used. ## Why It's Good For The Game It makes sense to be able to see screens without having to be right next to them. You will still be unable to interact with them, but you no longer need to be right next to them just to open up the UI. Laptops have also always required holding them in your hands to open up the UI, and this change should address that so that this is no longer necessary. ## Changelog :cl: add: Added ability to see screens using the examine_more function /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This PR makes it so that you can view a console, laptop, a wideband log, the screen on an APC, and the gasses measured from an air alarm, from one tile away. You can not interact with the UI unless you are right next to it. To do this, the examine_more function is used.
Why It's Good For The Game
It makes sense to be able to see screens without having to be right next to them. You will still be unable to interact with them, but you no longer need to be right next to them just to open up the UI. Laptops have also always required holding them in your hands to open up the UI, and this change should address that so that this is no longer necessary.
Changelog
🆑
add: Added ability to see screens using the examine_more function
/:cl: