qdel optimize #3558
qdel optimize #3558
Conversation
Signed-off-by: Feenie <[email protected]>
|
Main problem for compiling - no libdreamluau.so per compiling
|
|
A better solution than adding another auxtool modification maintained by one person we don't even have contact with would be actually just fixing harddels |
There was a problem hiding this comment.
Alright, so: this PR is alright, but you misunderstand what you ported here. Dreamluau doesn't change garbage collection/qdel at all, except for cleaning up its own references in the luau code. All the optimizations besides it that are in this PR is fine, but Dreamluau 100% does not need to be included here, there is absolutely no benefit it gives us, in fact, the only thing it could possibly do is slow down GC, even if by a trivial amount, because again, it only cleans up its own references, it doesn't touch the DM code at all.
Basically, this PR is in dire need of atomization. You can port Dreamluau in a different PR if you'd like, but this PR will not be merged with both qdel optimizations and a full port of an entirely unused external library.
Also, please make sure to credit the original TG PRs that added these changes, if you could please.
|
Done. Sorry, I'm low-sorted coder. |
Done |
|
Whyyyy?! How much I should update it? |
|
|
|
Any ideas for fix? |
|
I don't see any unit tests ran on there and its a drafted pr it really doesn't seem like its been "tested" there.
This also ports parts of |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes a few harddels that surfaced in PR #3558 ## Why It's Good For The Game Harddels are still just terrible wastes of time ## Changelog :cl: /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Done |
|
and and update your change log |
ready |
honestly, idk why it happens |
|
I fixed the harddel in #3572, this is fine to TM, ideally with my PR though |
|
everything is okay? |
|
are you kidding me... |
|
FINALLY |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
what's up with docker?.. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I made a mistake clearing up mine references, give me a moment to post an emergency pr |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request #3558 accidentally ported the JSON log support for qdel logs, despite the fact we still use old normal logs. This moves us back to the version we support, and also adds support ## Why It's Good For The Game qdel logs are nice to have for gauging prevalence of harddels ## Changelog :cl: server: qdel logs work again /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Fixes a few harddels that surfaced in PR shiptest-ss13#3558 ## Why It's Good For The Game Harddels are still just terrible wastes of time ## Changelog :cl: /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request That PR optimizes qdel and SSgarbage procs. Based on: tgstation/tgstation#79568 tgstation/tgstation#76956 tgstation/tgstation#80443 tgstation/tgstation#80628 ## Why It's Good For The Game Better performance. Tested on downstream: CeladonSS13#1025 ## Changelog :cl: code: Changing qdel() and SSgarbage procs code: rewrite /Destroy(force, silent) to /Destroy(force) /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. --> --------- Signed-off-by: Feenie <[email protected]>
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request shiptest-ss13#3558 accidentally ported the JSON log support for qdel logs, despite the fact we still use old normal logs. This moves us back to the version we support, and also adds support ## Why It's Good For The Game qdel logs are nice to have for gauging prevalence of harddels ## Changelog :cl: server: qdel logs work again /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
About The Pull Request
That PR optimizes qdel and SSgarbage procs.
Based on:
tgstation/tgstation#79568
tgstation/tgstation#76956
tgstation/tgstation#80443
tgstation/tgstation#80628
Why It's Good For The Game
Better performance. Tested on downstream: CeladonSS13#1025
Changelog
🆑
code: Changing qdel() and SSgarbage procs
code: rewrite /Destroy(force, silent) to /Destroy(force)
/:cl: