Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rock Outpost #3733

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

New Rock Outpost #3733

wants to merge 75 commits into from

Conversation

kaylexis
Copy link

@kaylexis kaylexis commented Nov 11, 2024

About The Pull Request

As stated in the title. Adds a new outpost, this time, a rock planet outpost! Screenshots below.
The plan is to make more for each missing planet type except for waste and lava(maybe).
Eventually I will finish these and PR them as well.

thank you zevo with the help for the stupid indestructible walls

Why It's Good For The Game

We only have 2 rotating outposts, and I don't like either of them personally.

Changelog

🆑
add: New outpost
add: Indestructible hematite subtype
add: Safe atmos rockplanet tile subtypes
add: Safe snow tile subtypes
change: replaces indestructible plastitanium with a better one
add: proper plastitanium glass indestructible turf
/:cl:

Pictures

WOAHITSREAL

image

image

hangar

image

image

@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. Code change Watch something violently break. labels Nov 11, 2024
@kaylexis
Copy link
Author

woops. marked as draft

@kaylexis kaylexis marked this pull request as ready for review November 11, 2024 01:44
@kaylexis kaylexis requested a review from a team as a code owner November 11, 2024 01:44
@kaylexis
Copy link
Author

someone else can fix the smoothing issues with indestructible plastitanium glass and walls. im confused and i'm not going to bother anymore

@kaylexis
Copy link
Author

kaylexis commented Nov 11, 2024

INTEGRATION TESTS SUCCEEDED!!! IM SO HAPPY
i can finally work on the other outpost maps..

@@ -25,6 +25,9 @@
/datum/map_template/outpost/elevator_ice
name = "elevator_ice"

/datum/map_template/outpost/elevator_rock
name = "elevator_rock"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@@ -25,6 +25,9 @@
/datum/map_template/outpost/elevator_ice
name = "elevator_ice"

/datum/map_template/outpost/elevator_rock
name = "elevator_rock"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "elevator_rock"
name = "elevator_rock"

actually the check is failing off this im stupif

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it actually failing off that shit o hmy god

@Apogee-dev
Copy link
Contributor

i feel like this really needs more of the NGR beige and pink floors in the office and sec areas. it just doesn't feel all that NGR-y without those fullcolor rooms because of just how distinctive they are.

yeah i see it now. i'll change some of the offices to have that style

other than that, maybe try using the tapered red line decals around the doors like on the ngr ships? might feel a little nicer than going straight to the full thickness version, but that's your call

issue with this is the side plating im using blocks out the tapered look of it, but i could pull it off with this, maybe? image

image

or like this.

First variant works for sure

@Latentish
Copy link
Member

You need to add pictures of your map to the pr description.
One in game
One of the SDMM without areas on
One of the SDMM with the Areas on

@kaylexis
Copy link
Author

You need to add pictures of your map to the pr description. One in game One of the SDMM without areas on One of the SDMM with the Areas on

added pictures

@Ratvarr
Copy link

Ratvarr commented Dec 21, 2024

THAT LAWNMOWER IS NOT HARD TO GET INTO YOU NEED TO MAKE THOSE BLASTDOORS NOT OPENABLE BY A FUCKING CROWBAR!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

@kaylexis
Copy link
Author

THAT LAWNMOWER IS NOT HARD TO GET INTO YOU NEED TO MAKE THOSE BLASTDOORS NOT OPENABLE BY A FUCKING CROWBAR!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

yeah i fixed that it has power now
those are like. the indestructible ert doors too. so. i guess they never expected them to not have power

@Burning02
Copy link
Contributor

Not sure if this has been said yet, but there's a stray refinery control console in the cryo chamber.
image

@kaylexis
Copy link
Author

Not sure if this has been said yet, but there's a stray refinery control console in the cryo chamber. image

oups

@Burning02
Copy link
Contributor

Not sure if this has been said yet, but there's a stray refinery control console in the cryo chamber. image

oups

Actually while I'm at it, you might wanna add a bolt button for the bathroom too? People don't tend to like having people accidently walk in while on the shitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Map Change Tile placing is hard. Thank you for your service. Test Merge Candidate You do it for free. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants