Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full Auto Mech Weaponry and Refresh #3739

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Gristlebee
Copy link
Contributor

About The Pull Request

Adds a component to facilitate full auto for certain mech weapons.
Ballistic mech weapons can now be set to eject casings.
Some general sanity changes for mech firecode.

The UMG mech machine gun is now full auto instead of burst fire. Max ammo capacity was cut in half to 600. Ammo boxes now hold 200 and cost 500 at the outpost.
Mech Scattershot now holds 12 rounds with a max ammo capacity of 72. Now fires 7 pellets up from 4, but is subject to damage falloff. Ammo boxes hold 24 rounds.
Mech disabler and light laser merged together into the Downpour energy carbine, which is fully automatic and can swap modes from the mech menu.
Mech heavy laser now fires an emitter blast instead.

Video Demonstration:

2024-11-11.15-21-21.mp4

Why It's Good For The Game

Mech weapons aren't terribly impressive for how big of an investment getting a combat mech is. These additions and changes should make them more fun to use and interesting to see. And really. Big automatic mech machine gun is cool as hell.

Changelog

🆑
add: Mech Full Auto
add: Mech scattergun now has 7 pellets, and damage falloff.
add: Mech guns can now eject casings.
add: Solaris fires an emitter blast.
add: Downpour energy carbine
del: Immolator laser, Peacemaker disabler
balance: Ammo capacity for UMG and Scattergun mech weapons. UMG ammo now costs 500 at the outpost.
/:cl:

@Gristlebee Gristlebee requested review from FalloutFalcon and a team as code owners November 11, 2024 23:47
@github-actions github-actions bot added Map Change Tile placing is hard. Thank you for your service. DME Edit Code change Watch something violently break. Ruin Ruin successfully tested. labels Nov 11, 2024
@Anticept
Copy link
Contributor

Anticept commented Nov 11, 2024

The UMG was prior discussed with apogee.

That thing is EXTREMELY strong. If you're allowing full auto, you really should reduce the damage.

It's basically an I win button.

@generalthrax
Copy link
Contributor

If you look closer I think it's actually a lower ttk than the burst. Since it's three bullets hitting in quick succession compared to this.

@Gristlebee
Copy link
Contributor Author

Gristlebee commented Nov 12, 2024

The UMG was prior discussed with apogee.

That thing is EXTREMELY strong. If you're allowing full auto, you really should reduce the damage.

It's basically an I win button.

When you're putting down anywhere from 15-20k~ to buy and equip a mech, it can stand to be a bit stronger.

And IMO, it's too early to say for certain. I'd like to see how it performs on live with a TM first. If it does end up being too strong and an instant win in practice, I'm more than happy to tone it down.

@Apogee-dev
Copy link
Contributor

The large bullet casing is a bit unnecessary, in that the exosuit ballistic weapons fire normal ammo- the UMG-2 is described as a light machine gun and the LBX-10 could be like.... 8ga or something. Neither's actually something normal weapons couldn't use, and explicit cartridges are just about always better than abstract.

honestly not changing that part of the descriptions when i renamed the exosuit weapons was a mistake

(also also, never use the word "mech" in descs and names, always use "exosuit")

@Anticept
Copy link
Contributor

Anticept commented Nov 12, 2024

If you look closer I think it's actually a lower ttk than the burst. Since it's three bullets hitting in quick succession compared to this.

The damage and armor pen haven't changed, and the ROF looks faster than burst to me. From his video, he was shooting center mass too on armored targets.

/obj/projectile/bullet/lmg
damage = 25
armour_penetration = 40

That's the damage values.

Now that said, I agree that the umg did need a little bit of a buff, apogee was thinking of it being okay to add a couple rounds to the burst, but that was the concern with that high armor pen. Two rounds will kill a limb and you're not going to find enough armor to prevent it.

Let's see what happens in TMs!

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict Use Git Hooks, you're welcome. label Dec 4, 2024
Copy link
Member

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for what its trying to do!

@github-actions github-actions bot requested a review from FalloutFalcon January 1, 2025 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. DME Edit Map Change Tile placing is hard. Thank you for your service. Ruin Ruin successfully tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants