-
-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Miskilamo Redecaling + Other Stuff #3807
Open
generalthrax
wants to merge
17
commits into
shiptest-ss13:master
Choose a base branch
from
generalthrax:mudskipper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+495
−418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Map Change
Tile placing is hard. Thank you for your service.
Ship
Ship successfully tested.
labels
Nov 19, 2024
generalthrax
changed the title
Minor Miskilamo Redecaling
Minor Miskilamo Redecaling + Other Stuff
Nov 19, 2024
Add ship numbers to the Mudskipper and Kilo while you’re at it- same spot as the shetland (aft starboard near the thrusters) if you can. Might need to shrink the kilo’s engineering window by a tile to fit. |
You accidentally placed some double catwalks on the kilo- fix that and we should be good |
think i got it |
Sadhorizon
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Minorly re-decals the Miskilamo line of ships. Mostly clearing out that sharp white against the grey / black that doesn't look that good. Kept it as consistent as I could throughout the three ships. I also did a few extra, smaller decaling in certain areas like crew quarters or areas with those weird grimy tiles.
Combines cryo and crewquarters into one area and combines the bathroom, washing machine room, and central hallway into one area as well for the Mudskipper.
Replaced the circular saw (angle grinder) with a plasmacutter.
Replaced the decaying armour vests with normal ones on the Kilo and Shetland.
Axes the airless turfs on the Kilo, and streamlines the big 2x3 airlocks on the Mudskipper and Shetland.
Why It's Good For The Game
This pr does very little other than getting rid of those white decals which I felt weird to me. Most everything else was unchanged.
Mudskipper area stuff was cut down a bit because the thing chugged as much power as a Riggs at half the size, on one pacman to boot. I don't think a room needs a APC for a washing machine and one lightbulb. It's a salvage ship so its probably fair to have a plasmacutter and angle grinder.
The presence of the Shitty armour vests felt like an odd choice. They just sit there eternally, worn by no one. May as well just have normal ones. Not like they're that big of an advantage in the grand scheme of things.
Changelog
🆑
del: Removed the white decaling from Miskilamo ships (Mudskipper, Kilo, Shetland)
balance: Mudskipper is now more compact on areas and has a plasmacutter
balance: Kilo and Shetland now have normal armour vests
fix: Kilo no longer has airless tiles under the prechargers, and airlocks should Work Better
/:cl: