Equip Delay #3854
Equip Delay #3854
Conversation
whoopsies
github-actions
bot
added
Sound
also grabs some I didn't get in the first pass equip noises stolen from cm
what the fuck is an interaction key
pleadster
also modsuit fix (yippee)
|
can we please tone it down from eight seconds? |
for stuff like spacesuits I think that's excessively reasonable, you should not be hotswapping in and out of space gear |
|
changed my mind, just do the defines and the leftofer slowdown define |
|
hi, I think regular clothes should not have an equip delay, and if they do, keep it really low since currently as fast as you can click off items is reasonably how fast you could get them off I-R-L relevant video, how it feels right now to put on a cap
soda.pop.zomboid.mp4personal opinion: I also thing the delay for pulling a backpack off your back should be shorter too, but this is a genuine personal opinion which can be ignored |
bottom text
|
I think it would be ideal if the delays were only on hardsuits. As it is, changing clothes is just slightly more irritating than before. Also, I'm not sure what we're improving here. |
|
Absolutely amazing feature. I really like this, but some comments on how it is currently after playing:
|
wrong pr |
plus assorted fixes
oversuits now have a 6 delay, same as undersuits
fixed handswapping, now cancels the do-after as intended
I may build this into a looping sound system instead of length-limited sound blocs. Investigating the framework for them rn
angle grinder fixed, others may need custom code later |
it's actually unbelievable that this works
|
I've replaced the equip time visual with the current, updated times. |
plus fix maybe? blinking so blinkily
|
taking gloves out of your pocket forces you to "take them off". |
okay that's funny |
me when 2 second delay to remove gloves from pocket |
|
taking your toolbelt off and backpack at the same time eradicates the backpack from reality |
curse you |
the fix I made paves over kapu's beautiful code meadow with a parking lot but it does fix it |
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request It now takes a moment to remove or equip clothing, triggering a do_after that places the item in the appropriate slot once completed. Base times are as follows:  You can move while equipping some lighter items, but it slows you down. Please thank @Kapu1178 for writing the better code in this pr, their work can also be found in [This PR](DaedalusDock/daedalusdock#1093) Comes with functionality for more sound effects being plugged in for different types of items. KNOWN ISSUES: - [x] Equip noises can be spammed by repeatedly clicking during the do_after <!-- Describe The Pull Request. Please be sure every change is documented or this can delay review and even discourage maintainers from merging your PR! --> ## Why It's Good For The Game My immersion More importance in picking the right gear for different situations. You can no longer hotswap in and out of stuff like spacesuits instantly, think a little more carefully about when to put them on. <!-- Please add a short description of why you think these changes would benefit the game. If you can't justify it in words, it might not be worth adding. --> ## Changelog :cl: Kapu1178 add: There is now a customizable delay for equipping and unequipping items from clothing slots. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
About The Pull Request
It now takes a moment to remove or equip clothing, triggering a do_after that places the item in the appropriate slot once completed.
Base times are as follows:
You can move while equipping some lighter items, but it slows you down.
Please thank @Kapu1178 for writing the better code in this pr, their work can also be found in This PR
Comes with functionality for more sound effects being plugged in for different types of items.
KNOWN ISSUES:
Why It's Good For The Game
My immersion
More importance in picking the right gear for different situations. You can no longer hotswap in and out of stuff like spacesuits instantly, think a little more carefully about when to put them on.
Changelog
🆑 Kapu1178
add: There is now a customizable delay for equipping and unequipping items from clothing slots.
/:cl: