Radio crackle QoL #3902
Merged
Radio crackle QoL #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiptest-server
pushed a commit
that referenced
this pull request
Jan 6, 2025
MrCat15352
pushed a commit
to MrCat15352/MrCat
that referenced
this pull request
Jan 8, 2025
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may not be viewable. --> <!-- You can view Contributing.MD for a detailed description of the pull request process. --> ## About The Pull Request Makes radio crackle a lot less spammy. Basically, first of all re-adds the toggle to disable it, second of all, simplifies the code into one place, and third of all, makes it so that messages (besides your own) only crackle when another message hasn't been sent in 5 seconds (subject to change). As a ~~side effect~~ totally intended feature, people using radios near you will instead play the much less intrusive radio message receive sound instead of the noisy walkie-talkie sound. ## Why It's Good For The Game Making it less repetitive and focusing it down to when it's actually needed is good for everyone. ## Changelog :cl: add: A pref to totally disable radio crackle sounds. tweak: Radio crackle will only play if it's been 5 seconds since the last radio message the mob has heard. tweak: The radio crackle will only play once a message has been successfully transmitted. /:cl: <!-- Both :cl:'s are required for the changelog to work! You can put your name to the right of the first :cl: if you want to overwrite your GitHub username as author ingame. --> <!-- You can use multiple of the same prefix (they're only used for the icon ingame) and delete the unneeded ones. Despite some of the tags, changelogs should generally represent how a player might be affected by the changes rather than a summary of the PR's contents. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes radio crackle a lot less spammy. Basically, first of all re-adds the toggle to disable it, second of all, simplifies the code into one place, and third of all, makes it so that messages (besides your own) only crackle when another message hasn't been sent in 5 seconds (subject to change).
As a
side effecttotally intended feature, people using radios near you will instead play the much less intrusive radio message receive sound instead of the noisy walkie-talkie sound.Why It's Good For The Game
Making it less repetitive and focusing it down to when it's actually needed is good for everyone.
Changelog
🆑
add: A pref to totally disable radio crackle sounds.
tweak: Radio crackle will only play if it's been 5 seconds since the last radio message the mob has heard.
tweak: The radio crackle will only play once a message has been successfully transmitted.
/:cl: