Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

melee combat rework test #3951

Closed
wants to merge 119 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
119 commits
Select commit Hold shift + click to select a range
6083109
orginize some weapon sprites
FalloutFalcon Apr 11, 2024
f81394f
more orginzing
FalloutFalcon Apr 11, 2024
ae8b538
new sprites mabye
FalloutFalcon Apr 11, 2024
925010f
fix energy weapon icon path
FalloutFalcon Apr 11, 2024
4adba95
orginizes files
FalloutFalcon Apr 13, 2024
4a76632
cruft
FalloutFalcon Apr 13, 2024
b9c2bdf
yea
FalloutFalcon Apr 13, 2024
e03cb56
orginizes primal and clothing cat (cherrypicked)
FalloutFalcon Mar 21, 2024
4f1bd7f
orginizes some more recipes
FalloutFalcon Apr 13, 2024
57b39e9
recipe cruft
FalloutFalcon Apr 14, 2024
68903db
yea
FalloutFalcon Apr 14, 2024
4053cc9
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Apr 14, 2024
b6fab46
trailing whitespace
FalloutFalcon Apr 14, 2024
bacc3d4
better sword parent
FalloutFalcon Apr 14, 2024
4ff3443
renove null rod
FalloutFalcon Apr 14, 2024
11bfe91
yuh
FalloutFalcon Apr 14, 2024
ac1b4a2
bad type
FalloutFalcon Apr 14, 2024
7f316d6
remaps chappy armor
FalloutFalcon Apr 14, 2024
f3ded51
ytea
FalloutFalcon Apr 14, 2024
dc8d07f
axe parent type, removes magic hammers
FalloutFalcon Apr 14, 2024
e4d9d66
stuff
FalloutFalcon Apr 14, 2024
e4671a6
removing cult weapons
FalloutFalcon Apr 14, 2024
3fb28b7
oops
FalloutFalcon Apr 14, 2024
e2fccf8
oops
FalloutFalcon Apr 14, 2024
d26bf9f
what if i just deleted the cult file haha so silly
FalloutFalcon Apr 15, 2024
2171f22
Revert "what if i just deleted the cult file haha so silly"
FalloutFalcon Apr 15, 2024
aa6115b
fixing sprites by removing stuff mostly c:
FalloutFalcon Apr 15, 2024
83a92e0
removes bostaff cruft item (tho i do want a cool matrial staff)
FalloutFalcon Apr 15, 2024
d7a2276
almost passing i think
FalloutFalcon Apr 15, 2024
f8a9ff4
damn bone spear was like better then a plasma spear what the hell
FalloutFalcon Apr 15, 2024
9ecd1ea
new weapons!
FalloutFalcon Apr 15, 2024
d0fa531
gives scrap vest ok armour
FalloutFalcon Apr 15, 2024
c656b54
scrap armor
FalloutFalcon Apr 15, 2024
133c694
swords blulky by default
FalloutFalcon Apr 15, 2024
ddfb8df
no armour for tribal pins
FalloutFalcon Apr 15, 2024
6ab22f6
removes some random cruft sprites to clean up items_and_weapons
FalloutFalcon Apr 15, 2024
e7faee2
renames items_and_weapons because why is its name so big omg
FalloutFalcon Apr 15, 2024
1df55bc
more dmi stuff
FalloutFalcon Apr 15, 2024
9f239b6
knife parent
FalloutFalcon Apr 15, 2024
4619cec
combat knife doesnt realyl affect survival or bone
FalloutFalcon Apr 15, 2024
a82ab89
insane
FalloutFalcon Apr 15, 2024
9df3b5f
minor path fixing
FalloutFalcon Apr 15, 2024
2b37b9e
yea
FalloutFalcon Apr 16, 2024
504566f
Merge branch 'master' into improv
FalloutFalcon Apr 24, 2024
1cbb43a
yea
FalloutFalcon Apr 24, 2024
98733cc
make fixing new ruins made during this pr easier to fix
FalloutFalcon Apr 24, 2024
4212422
spears
FalloutFalcon Apr 24, 2024
12c6006
This hurt. Merge branch 'master' of https://github.com/shiptest-ss13/…
FalloutFalcon Sep 13, 2024
5902a54
regex and banishing tribal.dm once more
FalloutFalcon Sep 13, 2024
34f272d
regex
FalloutFalcon Sep 13, 2024
d0f04f6
oops!
FalloutFalcon Sep 13, 2024
aa8ce55
repath kitcken knives
FalloutFalcon Sep 13, 2024
3a561a9
bunch more repaths from merge
FalloutFalcon Sep 13, 2024
efa1cba
kitchen not kitcken
FalloutFalcon Sep 13, 2024
8c66360
more repaths
FalloutFalcon Sep 13, 2024
7ba778d
why did regex add new lines wtf
FalloutFalcon Sep 13, 2024
4891293
yea!
FalloutFalcon Sep 13, 2024
f57b1d4
Merge branch 'master' into oops-all-refactors
FalloutFalcon Sep 16, 2024
eecbfef
Merge branch 'master' into oops-all-refactors
FalloutFalcon Sep 19, 2024
b3a5f7f
transforming component, stunbaton span defines, wip items
FalloutFalcon Sep 19, 2024
9e42991
oh this is transforming weapon pr now?
FalloutFalcon Sep 19, 2024
0f0c30a
the repathing... god if this conflict merges
FalloutFalcon Sep 19, 2024
c79296a
updates icon states
FalloutFalcon Sep 19, 2024
c5f0cce
more missing icon_state
FalloutFalcon Sep 19, 2024
0b8b15f
better unit tests to help me
FalloutFalcon Sep 19, 2024
85117b8
tweak to test, only fail if only 1 inhand is missing cause then its c…
FalloutFalcon Sep 19, 2024
8970218
tweaks to unit tests again
FalloutFalcon Sep 19, 2024
e1ef45b
what if i just did it again
FalloutFalcon Sep 19, 2024
a72ffaf
tweaks so that its eaiser to search for _w and _on
FalloutFalcon Sep 19, 2024
c7a992e
bad_types?
FalloutFalcon Sep 19, 2024
2abc862
oops!
FalloutFalcon Sep 19, 2024
5aa1d01
isbadpath
FalloutFalcon Sep 19, 2024
8767f3c
ah wrong name for that
FalloutFalcon Sep 19, 2024
19d7125
to save me some time
FalloutFalcon Sep 19, 2024
5d41d1e
oh i see
FalloutFalcon Sep 19, 2024
c5ccfcb
I have a feeling its broken
FalloutFalcon Sep 19, 2024
1a89aba
more useful test one sec
FalloutFalcon Sep 19, 2024
33a7a17
wow i forgot that
FalloutFalcon Sep 19, 2024
2f95dd4
thats prob why these werent working
FalloutFalcon Sep 19, 2024
5508d0b
only run overkill icon tests when asked
FalloutFalcon Sep 19, 2024
3f5f71e
this looks really ugly tbh
FalloutFalcon Sep 19, 2024
faf2610
prob a cleaner way to do this
FalloutFalcon Sep 19, 2024
071b117
this is so out of scope
FalloutFalcon Sep 19, 2024
198bab2
can now work on pedang
FalloutFalcon Sep 19, 2024
71a3bef
pedang wip
FalloutFalcon Sep 19, 2024
4137a82
yea
FalloutFalcon Sep 22, 2024
16d57a6
component based behavior
FalloutFalcon Sep 23, 2024
30b6c42
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Sep 23, 2024
ad27e30
no longer doing charged parent type. we all in with the componenet
FalloutFalcon Sep 23, 2024
7523426
more stuff working as charged comp
FalloutFalcon Sep 23, 2024
0edcf07
get_best_shield needs to be refactored but whatever.
FalloutFalcon Sep 23, 2024
5fd0bae
riposte!
FalloutFalcon Sep 23, 2024
cd9e666
holy crap i love reposte
FalloutFalcon Sep 24, 2024
bfd353a
more improvments to charged.
FalloutFalcon Sep 24, 2024
a3e8fe6
shocking
FalloutFalcon Sep 24, 2024
05f5697
attack_cooldown
FalloutFalcon Sep 29, 2024
43b0223
diffrent cd's pending balance
FalloutFalcon Sep 30, 2024
2892509
better force string and readds world icons i somehow removed.
FalloutFalcon Sep 30, 2024
21cf5f0
energy weapons dont need the transforming parent type
FalloutFalcon Sep 30, 2024
57de0bf
tweaks to two handed stuff to make it more maintaiable
FalloutFalcon Sep 30, 2024
235e47e
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Sep 30, 2024
e551a82
better duel energy weapon path
FalloutFalcon Sep 30, 2024
ca0606d
70 lines only for halberds. not bad
FalloutFalcon Sep 30, 2024
274188a
oh its just a varedit
FalloutFalcon Sep 30, 2024
28fcdaf
few things broke. those are fixed now
FalloutFalcon Sep 30, 2024
78b3f4e
yea
FalloutFalcon Sep 30, 2024
63852fa
mass sword stuff...
FalloutFalcon Sep 30, 2024
5f429b7
sound design
FalloutFalcon Oct 1, 2024
b50d974
the sledge
FalloutFalcon Oct 1, 2024
48f4f5c
Merge branch 'master' of https://github.com/shiptest-ss13/Shiptest in…
FalloutFalcon Dec 31, 2024
7bb054b
merge fixes
FalloutFalcon Dec 31, 2024
062ab7b
stuff!
FalloutFalcon Dec 31, 2024
f168675
more tweaks
FalloutFalcon Dec 31, 2024
91dd36c
knucklebuster proof of concept
FalloutFalcon Dec 31, 2024
398256a
yea
FalloutFalcon Jan 1, 2025
ed491b1
cleanup
FalloutFalcon Jan 3, 2025
3772cbc
parrying ports from paridise
FalloutFalcon Jan 4, 2025
407000c
some sprites from stiel
FalloutFalcon Jan 4, 2025
51db39b
removes bladeatheon file, small icon fixes
FalloutFalcon Jan 4, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _maps/RandomRuins/IceRuins/icemoon_crashed_holemaker.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,7 @@
/obj/effect/turf_decal/spline/fancy/transparent/neutral/corner{
dir = 1
},
/obj/item/dualsaber/toy,
/obj/item/melee/duelenergy/saber/toy,
/turf/open/floor/plasteel/icemoon,
/area/ruin/unpowered/crashed_holemaker)
"rm" = (
Expand Down
4 changes: 2 additions & 2 deletions _maps/RandomRuins/SpaceRuins/spacemall.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -6315,7 +6315,7 @@
"xM" = (
/obj/structure/rack,
/obj/effect/turf_decal/corner/transparent/black/diagonal,
/obj/item/dualsaber/toy,
/obj/item/melee/duelenergy/saber/toy,
/turf/open/floor/plasteel,
/area/ruin/space/has_grav/spacemall/shop2)
"xN" = (
Expand Down Expand Up @@ -11422,7 +11422,7 @@
/turf/open/floor/plating/grass,
/area/ruin/space/has_grav/spacemall)
"QO" = (
/obj/item/dualsaber/toy,
/obj/item/melee/duelenergy/saber/toy,
/obj/item/toy/redbutton{
pixel_x = 14
},
Expand Down
4 changes: 2 additions & 2 deletions _maps/shuttles/syndicate/syndicate_ngr_derecho.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -3529,8 +3529,8 @@
/obj/machinery/light/small/directional/south,
/obj/machinery/firealarm/directional/east,
/obj/effect/decal/cleanable/dirt/dust,
/obj/item/melee/axe/sledgehammer,
/obj/item/melee/axe/sledgehammer{
/obj/item/melee/sledgehammer/gorlex,
/obj/item/melee/sledgehammer/gorlex{
pixel_x = 5
},
/turf/open/floor/pod,
Expand Down
2 changes: 1 addition & 1 deletion _maps/shuttles/syndicate/syndicate_ngr_kaliandhi.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -6126,7 +6126,7 @@
"Ol" = (
/obj/structure/rack,
/obj/machinery/airalarm/directional/south,
/obj/item/melee/axe/sledgehammer,
/obj/item/melee/sledgehammer/gorlex,
/turf/open/floor/plasteel/dark,
/area/ship/hallway/fore)
"On" = (
Expand Down
8 changes: 8 additions & 0 deletions code/__DEFINES/combat.dm
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
//Actual combat defines

//click cooldowns, in tenths of a second, used for various combat actions
#define HEAVY_WEAPON_CD 10
#define CLICK_CD_MELEE 8
#define LIGHT_WEAPON_CD 6
#define CLICK_CD_RANGE 4
#define CLICK_CD_RAPID 2
#define CLICK_CD_CLICK_ABILITY 6
Expand All @@ -49,6 +51,7 @@
#define CLICK_CD_RESIST 20
#define CLICK_CD_GRABBING 10
#define CLICK_CD_LOOK_UP 5
#define CLICK_CD_PARRY 8

//Cuff resist speeds
#define FAST_CUFFBREAK 1
Expand All @@ -74,6 +77,11 @@
#define PROJECTILE_ATTACK 3
#define THROWN_PROJECTILE_ATTACK 4
#define LEAP_ATTACK 5
#define ALL_ATTACK_TYPES list(MELEE_ATTACK, UNARMED_ATTACK, PROJECTILE_ATTACK, THROWN_PROJECTILE_ATTACK, LEAP_ATTACK)
#define NON_PROJECTILE_ATTACKS list(MELEE_ATTACK, UNARMED_ATTACK, LEAP_ATTACK)

// the standard parry time out time
#define PARRY_DEFAULT_TIMEOUT 1 SECONDS

//attack visual effects
#define ATTACK_EFFECT_PUNCH "punch"
Expand Down
3 changes: 3 additions & 0 deletions code/__DEFINES/dcs/signals/signals_mob/signals_mob_carbon.dm
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@
#define COMSIG_HUMAN_CHECK_SHIELDS "human_check_shields"
#define SHIELD_BLOCK (1<<0)

//sent from living mobs when they parry
#define COMSIG_HUMAN_PARRY "human_parry"

// Mob transformation signals
///Called when a human turns into a monkey, from /mob/living/carbon/proc/finish_monkeyize()
#define COMSIG_HUMAN_MONKEYIZE "human_monkeyize"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
#define COMPONENT_BLOCK_MARK_RETRIEVAL 1
#define COMSIG_ITEM_WEARERCROSSED "wearer_crossed" //called on item when crossed by something (): (/atom/movable, mob/living/crossed)

#define COMSIG_ITEM_UNIQUE_ACTION "item_unique_action" //from base of obj/item/unique_action(): (mob/living/user)

///from base of item/sharpener/attackby(): (amount, max)
#define COMSIG_ITEM_SHARPEN_ACT "sharpen_act"
#define COMPONENT_BLOCK_SHARPEN_APPLIED 1
Expand Down
1 change: 1 addition & 0 deletions code/__DEFINES/keybinding.dm
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#define COMSIG_KB_HUMAN_QUICKEQUIP_DOWN "keybinding_human_quickequip_down"
#define COMSIG_KB_HUMAN_QUICKEQUIPBELT_DOWN "keybinding_human_quickequipbelt_down"
#define COMSIG_KB_HUMAN_UNIQUEACTION "keybinding_uniqueaction"
#define COMSIG_KB_HUMAN_PARRY "keybinding_parry"
#define COMSIG_KB_HUMAN_BAGEQUIP_DOWN "keybinding_human_bagequip_down"
#define COMSIG_KB_HUMAN_EQUIPMENTSWAP_DOWN "keybinding_human_equipmentswap_down"
#define COMSIG_KB_HUMAN_SUITEQUIP_DOWN "keybinding_human_suitequip_down"
Expand Down
6 changes: 3 additions & 3 deletions code/_onclick/item_attack.dm
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@
if((I.item_flags & SURGICAL_TOOL) && user.a_intent == INTENT_HELP)
if(attempt_initiate_surgery(I, src, user))
return TRUE
user.changeNext_move(CLICK_CD_MELEE)
//This should really be in attack but 2 much logic doesnt call parent
user.changeNext_move(I.attack_cooldown)
return I.attack(src, user)

/mob/living/attack_hand(mob/living/user)
Expand Down Expand Up @@ -126,14 +127,13 @@
log_combat(user, M, "attacked", src.name, "(INTENT: [uppertext(user.a_intent)]) (DAMTYPE: [uppertext(damtype)])")
add_fingerprint(user)


/// The equivalent of the standard version of [/obj/item/proc/attack] but for object targets.
/obj/item/proc/attack_obj(obj/O, mob/living/user)
if(SEND_SIGNAL(src, COMSIG_ITEM_ATTACK_OBJ, O, user) & COMPONENT_NO_ATTACK_OBJ)
return
if(item_flags & NOBLUDGEON)
return
user.changeNext_move(CLICK_CD_MELEE)
user.changeNext_move(attack_cooldown)
user.do_attack_animation(O)
O.attacked_by(src, user)

Expand Down
127 changes: 0 additions & 127 deletions code/datums/components/melee/charged.dm

This file was deleted.

Loading
Loading