Skip to content

Commit

Permalink
Add missing changes in the generated buildRun CRD (#253)
Browse files Browse the repository at this point in the history
- Add missing spec.output declaration in the buildrun. I think
  this was missing in #233
- Add missing timeout in spec.status.buildSpec, I think this was missed
 somehow after #158 was merged.

Also, this can be reproduced by doing `operator-sdk generate crds`
  • Loading branch information
qu1queee authored Jun 7, 2020
1 parent 10a6788 commit 40088f6
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions deploy/crds/build.dev_buildruns_crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,26 @@ spec:
required:
- name
type: object
output:
description: Output refers to the location where the generated image
would be pushed to. It will overwrite the output image in build spec
properties:
credentials:
description: SecretRef is a reference to the Secret containing the
credentials to push the image to the registry
properties:
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Add other useful fields. apiVersion, kind, uid?'
type: string
type: object
image:
description: ImageURL is the URL where the image will be pushed
to.
type: string
required:
- image
type: object
resources:
description: 'Compute Resources required by the build container which
can overwrite the configuration in Build. More info: https://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/'
Expand Down Expand Up @@ -262,6 +282,9 @@ spec:
required:
- name
type: object
timeout:
description: Timeout defines the maximum run time of a build run.
type: string
required:
- output
- source
Expand Down

0 comments on commit 40088f6

Please sign in to comment.