Merge pull request #1029 from SaschaSchwarze0/sascha-1028-buildah-ima…

…ge-digest Use BuildAh --digestfile argument to store digest of pushed image
shipwright-io · Mar 31, 2022 · 9a40e9c · 9a40e9c
2 parents 4ba48bb + 2534414
commit 9a40e9c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 26 deletions.
diff --git a/samples/buildstrategy/buildah/buildstrategy_buildah_cr.yaml b/samples/buildstrategy/buildah/buildstrategy_buildah_cr.yaml
@@ -145,22 +145,10 @@ spec:
           # Push the image
           echo "[INFO] Pushing image ${image}"
           buildah push \
+            --digestfile='$(results.shp-image-digest.path)' \
             --tls-verify="${tlsVerify}" \
             "${image}" \
             "docker://${image}"
-
-          # Store the digest result. This is more complex than expected. BuildAh locally calculates a wrong digest.
-          # We therefore tag the image to a dummy name so that the layers are still present. Then we remove the local
-          # tag. Then we pull again. Then the local digest is correct.
-          # This should be validated again with a newer BuildAh version.
-          # https://github.com/containers/buildah/issues/3866
-          buildah tag "${image}" dummy
-          buildah rmi "${image}"
-          buildah pull --tls-verify="${tlsVerify}" "${image}"
-          buildah inspect \
-            --type=image \
-            --format='{{.FromImageDigest}}' \
-            "${image}" > '$(results.shp-image-digest.path)'
         # That's the separator between the shell script and its args
         - --
         - --context

diff --git a/samples/buildstrategy/source-to-image/buildstrategy_source-to-image-redhat_cr.yaml b/samples/buildstrategy/source-to-image/buildstrategy_source-to-image-redhat_cr.yaml
@@ -109,21 +109,9 @@ spec:
           # Push the image
           echo "[INFO] Pushing image ${image}"
           buildah push \
+            --digestfile='$(results.shp-image-digest.path)' \
             --tls-verify="${tlsVerify}" \
             "docker://${image}"
-          
-          # Store the digest result. This is more complex than expected. BuildAh locally calculates a wrong digest.
-          # We therefore tag the image to a dummy name so that the layers are still present. Then we remove the local
-          # tag. Then we pull again. Then the local digest is correct.
-          # This should be validated again with a newer BuildAh version.
-          # https://github.com/containers/buildah/issues/3866
-          buildah tag "${image}" dummy
-          buildah rmi "${image}"
-          buildah pull --tls-verify="${tlsVerify}" "${image}"
-          buildah inspect \
-            --type=image \
-            --format='{{.FromImageDigest}}' \
-            "${image}" > '$(results.shp-image-digest.path)'
         # That's the separator between the shell script and its args
         - --
         - --image