Merge pull request #683 from ImJasonH/flavor

Remove unused fields from GitSource
shipwright-io · Mar 22, 2021 · c086190 · c086190
2 parents 0430ccc + 72e733a
commit c086190
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 40 deletions.
diff --git a/deploy/crds/shipwright.io_buildruns.yaml b/deploy/crds/shipwright.io_buildruns.yaml
@@ -261,20 +261,6 @@ spec:
                               TODO: Add other useful fields. apiVersion, kind, uid?'
                             type: string
                         type: object
-                      flavor:
-                        description: Flavor of the git provider like github, gitlab,
-                          bitbucket, generic, etc. Optional.
-                        type: string
-                      httpProxy:
-                        description: HTTPProxy is optional.
-                        type: string
-                      httpsProxy:
-                        description: HTTPSProxy is optional.
-                        type: string
-                      noProxy:
-                        description: NoProxy can be used to specify domains for which
-                          no proxying should be performed. Optional.
-                        type: string
                       revision:
                         description: Ref is a git reference. Optional. If not defined,
                           it will fallback to the git repository default branch.

diff --git a/deploy/crds/shipwright.io_builds.yaml b/deploy/crds/shipwright.io_builds.yaml
@@ -202,20 +202,6 @@ spec:
                           TODO: Add other useful fields. apiVersion, kind, uid?'
                         type: string
                     type: object
-                  flavor:
-                    description: Flavor of the git provider like github, gitlab, bitbucket,
-                      generic, etc. Optional.
-                    type: string
-                  httpProxy:
-                    description: HTTPProxy is optional.
-                    type: string
-                  httpsProxy:
-                    description: HTTPSProxy is optional.
-                    type: string
-                  noProxy:
-                    description: NoProxy can be used to specify domains for which
-                      no proxying should be performed. Optional.
-                    type: string
                   revision:
                     description: Ref is a git reference. Optional. If not defined,
                       it will fallback to the git repository default branch.

diff --git a/pkg/apis/build/v1alpha1/gitsource.go b/pkg/apis/build/v1alpha1/gitsource.go
@@ -22,18 +22,6 @@ type GitSource struct {
 	// +optional
 	ContextDir *string `json:"contextDir,omitempty"`
 
-	// HTTPProxy is optional.
-	HTTPProxy string `json:"httpProxy,omitempty"`
-
-	// HTTPSProxy is optional.
-	HTTPSProxy string `json:"httpsProxy,omitempty"`
-
-	// NoProxy can be used to specify domains for which no proxying should be performed. Optional.
-	NoProxy string `json:"noProxy,omitempty"`
-
 	// SecretRef refers to the secret that contains credentials to access the git repo. Optional.
 	SecretRef *corev1.LocalObjectReference `json:"credentials,omitempty"`
-
-	// Flavor of the git provider like github, gitlab, bitbucket, generic, etc. Optional.
-	Flavor string `json:"flavor,omitempty"`
 }