Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --snapshot-mode instead of --snapshotMode and --tar-path instead --tarPath in sample build strategies that use Kaniko #1361

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Use --snapshot-mode instead of --snapshotMode and --tar-path instead --tarPath in sample build strategies that use Kaniko #1361

merged 1 commit into from
Aug 23, 2023

Conversation

SaschaSchwarze0
Copy link
Member

Changes

Already last year, Kaniko cleaned up command line flags to make naming consistent. The snapshotMode and tarPath are deprecated and cause a warning. Adopting our strategy example to use snapshot-mode and tar-path.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The Kaniko sample build strategy now uses the --snapshot-mode and --tar-path command line flags instead of the deprecated --snapshotMode and --tarPath

@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 21, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Aug 21, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 21, 2023
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Aug 21, 2023
@SaschaSchwarze0 SaschaSchwarze0 changed the title Use --snapshot-mode instead of --snapshotMode and --tar-path instead --tarPath Use --snapshot-mode instead of --snapshotMode and --tar-path instead --tarPath in sample build strategies that use Kaniko Aug 21, 2023
qu1queee
qu1queee approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides Corey comments

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2023
@coreydaley
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2023
@coreydaley
Copy link
Contributor

/approve

1 similar comment
@SaschaSchwarze0
Copy link
Member Author

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreydaley, SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 584e337 into shipwright-io:main Aug 23, 2023
11 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-kaniko-flag branch August 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coreydaley coreydaley coreydaley approved these changes

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@otaviof otaviof Awaiting requested review from otaviof

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees

@qu1queee qu1queee

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SaschaSchwarze0 @coreydaley @qu1queee @openshift-merge-robot