Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing spec.output.insecure flag to beta API #1378

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Add missing spec.output.insecure flag to beta API #1378

merged 1 commit into from
Sep 11, 2023

Conversation

SaschaSchwarze0
Copy link
Member

Changes

The flag was introduced as part of shipwright-managed push and is missing in the Beta API.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Sep 6, 2023
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Sep 6, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 6, 2023
qu1queee
qu1queee approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 793b79f into shipwright-io:main Sep 11, 2023
12 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-output-insecure branch August 7, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SaschaSchwarze0 @qu1queee @openshift-merge-robot