Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure conversion for local source takes place #1403

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Ensure conversion for local source takes place #1403

merged 7 commits into from
Oct 18, 2023

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Oct 13, 2023 •
edited
Loading

Changes

Add conversion for local type. Previously local type was supported under .spec.sources for Builds and Buildruns( v1alpha1 ). In this PR, we move local sources as the third supported type for .spec.source in Builds( v1beta1 ) and as the only supported type in .spec.source in BuildRuns( v1beta1 ).

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add conversion logic for local type of sources. BuildRun CRs now support a .spec.source object that can only be of the type Local. Build CRs now make it explicit on support for the .spec.source of the type Local.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2023
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Oct 13, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.12.0 milestone Oct 16, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2023
@qu1queee qu1queee force-pushed the qu1queee/conversion_local_source branch from 28d2e96 to 506fd72 Compare October 17, 2023 17:40
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
@qu1queee qu1queee force-pushed the qu1queee/conversion_local_source branch 2 times, most recently from 620bd2f to 416c26a Compare October 18, 2023 09:32
@qu1queee qu1queee added kind/documentation Categorizes issue or PR as related to documentation. kind/design Categorizes issue or PR as related to design. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Oct 18, 2023
@qu1queee qu1queee marked this pull request as ready for review October 18, 2023 12:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@qu1queee
Ensure conversion for local source takes place
c3f2045 
- Introduce missing localType object in spec.source for Build
- Introduce new spec.source object for BuildRun
- Ensure conversion for spec.sources in Build or spec.sources in
  BuildRun can convert to the spec.source for beta
@qu1queee
Add conversion webhook unit test for local
412e4b2 
- Validate conversion from beta to alpha, alpha to beta, for the Build
  CR's.
- Validate conversion from beta to alpha, alpha to beta, for the
  BuildRun CR's.
@qu1queee
add docs on br source
e22ca65
@qu1queee
Make the buildrun.spec.build a mandatory field
9ef8506 
Due to seeing panics reported in issues, when this field
for v1beta1 CR's was not set by human error.
@qu1queee qu1queee force-pushed the qu1queee/conversion_local_source branch from c776d8b to 9ef8506 Compare October 18, 2023 14:42
@qu1queee qu1queee removed the request for review from otaviof October 18, 2023 14:56
SaschaSchwarze0
SaschaSchwarze0 reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qu1queee can you check qu1queee#34 ?

@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2023
SaschaSchwarze0
SaschaSchwarze0 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2023
@SaschaSchwarze0 SaschaSchwarze0 merged commit f8a2b63 into shipwright-io:main Oct 18, 2023
12 checks passed
@SaschaSchwarze0 SaschaSchwarze0 mentioned this pull request Oct 19, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@qu1queee @SaschaSchwarze0