Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for v1beta1-localsource #1422

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

apoorvajagtap
Copy link
Member

@apoorvajagtap apoorvajagtap commented Oct 30, 2023

Changes

Fixes #1414

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 30, 2023
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2023
@openshift-ci openshift-ci bot requested review from otaviof and qu1queee October 30, 2023 14:38
@apoorvajagtap
Copy link
Member Author

/assign @qu1queee @SaschaSchwarze0

@apoorvajagtap
Copy link
Member Author

/kind test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

@apoorvajagtap: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 6, 2023
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2023
Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Nov 7, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 0d8d3f4 into shipwright-io:main Nov 7, 2023
12 checks passed
@apoorvajagtap apoorvajagtap deleted the issue_1414 branch November 7, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] e2e test cases missing for LocalSource
3 participants