Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a file or directory having a name with two subsequent dots while still preventing path traversal #1429

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Allow a file or directory having a name with two subsequent dots while still preventing path traversal #1429

merged 1 commit into from
Nov 9, 2023

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Nov 9, 2023 •
edited
Loading

Changes

When we prevent path traversal when extracting a source bundle, we were too strict. We only need to prevent /../ because this means to go one directory up. We still must allow .. because a directory or file can contain two subsequent dots in its name.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

You can now use files and directories with two subsequent dots in its name when using an OCI artifact as source

@SaschaSchwarze0 SaschaSchwarze0 added the kind/bug Categorizes issue or PR as related to a bug. label Nov 9, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Nov 9, 2023
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Nov 9, 2023
@openshift-ci openshift-ci bot requested a review from otaviof November 9, 2023 10:57
qu1queee
qu1queee approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2023
@SaschaSchwarze0 SaschaSchwarze0 merged commit 3a85565 into shipwright-io:main Nov 9, 2023
12 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-all-doubledot-in-name branch November 9, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

@otaviof otaviof Awaiting requested review from otaviof

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SaschaSchwarze0 @qu1queee