Cleanup Buildpacks strategies #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaSchwarze0
added
the
kind/cleanup
openshift-ci
bot
added
the
release-note-none
pull-request-size
bot
added
the
size/XXL
qu1queee
requested changes
Nov 13, 2023
SaschaSchwarze0
force-pushed
the
sascha-cleanup-buildpacks-strategies
branch
from
fbe7c3a to
3ddb9ff
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1295
We still had references to Heroku using Ubuntu 18 in unit tests and documentation. I updated that. While searching for Heroku usage, I noticed a duplication of the Alpha build strategies in /samples/v1alpha1/buildstrategies/buildstrategies. I removed that.
Submitter Checklist
Release Notes