Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes on docs and types #1519

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Minor fixes on docs and types #1519

merged 1 commit into from
Mar 4, 2024

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Mar 4, 2024 •
edited by SaschaSchwarze0
Loading

Changes

Mainly for build sources and usage of OCIArtifact.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@qu1queee
Minor fixes on docs and types
171ceb9 
Mainly for build sources and usage of OCIArtifact.
@qu1queee qu1queee added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 4, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Mar 4, 2024
@openshift-ci openshift-ci bot requested review from adambkaplan and otaviof March 4, 2024 12:24
@qu1queee qu1queee requested review from HeavyWombat and SaschaSchwarze0 and removed request for otaviof March 4, 2024 12:24
SaschaSchwarze0
SaschaSchwarze0 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 4, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8544347 into shipwright-io:main Mar 4, 2024
13 checks passed
@qu1queee qu1queee deleted the qu1queee/on_apis branch March 4, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@HeavyWombat HeavyWombat Awaiting requested review from HeavyWombat

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Archived in project
Milestone
release-v0.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@qu1queee @SaschaSchwarze0