Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump easimon/maximize-build-space from 8 to 10 #1523

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 4, 2024

Bumps easimon/maximize-build-space from 8 to 10.

Release notes

Sourced from easimon/maximize-build-space's releases.

Fix: Build Mount folder Ownership

What's Changed

  • fix: if the build mount "deleted" / shadowed the GITHUB_WORKSPACE, do not only recreate it, but also ensure it belongs to the correct owner (runner) again

Full Changelog: easimon/maximize-build-space@v9...v10

Allow build mount path to be a parent of $GITHUB_WORKSPACE

This release adds support for mounting the build volume over a parent folder of $GITHUB_WORKSPACE.

Previously, doing so would remove/shadow the current working directory, and make any later actions/steps fail.

New features:

  • Warn about $BUILD_MOUNT_PATH not being empty and list contents in that case
  • Recreate $GITHUB_WORKSPACE afterwards if missing, so following actions have a working directory to start from.
Changelog

Sourced from easimon/maximize-build-space's changelog.

Changelog

[v4] - 2021-03-25: Do not overprovision space by default

Added

  • Configuration option of overprovisioning the build volume (overprovision-lvm), defaulting to 'false'.
  • Configurable temp volume reserve (temp-reserve-mb), defaulting to '100'.

Changed

  • (potentially breaking) The LVM image files are not created sparsely anymore. Previously, free disk space appeared free on both the build volume and the hosting volume, until actually allocated by writing to the build volume. Now, the space is actually consumed on volume creation -- meaning, that after creating the build volume, the root and temp volume do not have or show more space available than configured in root-reserve-mb and temp-reserve-mb. This can be reverted by setting overprovision-lvm to 'true', but surprising out-of-disk space situations might be the result.
  • Temp volume reserve was fixed to 1024 KB, this defaults to a more cautious 100 MB now, and is configurable.

[v3] - 2021-02-15: Fix running on Ubuntu 20.04

Changed

  • Includes a workaround for the temp disk being locked on Ubuntu 20.04. Instead of formatting the temp disk, the LVM volume is now created ontop of loop-mounted files on both / and /mnt, leaving the original file systems intact.

[v2] - 2021-01-05: Fix file system permissions on logical volume

Changed

  • Change the owner of the logical volume to the runner user recursively, fixing permission issues when e.g. checking out code to the root of the logical volume. (Actually, the problem is the lost+found folder in the ext4 root, and chowning it breaks its purpose. But since the volume is temporary anyway, lost+found functionality is not really needed).

[v1] - 2020-08-20: Initial release

Commits
  • fc881a6 Merge pull request #36 from easimon/fix/ownership-of-github-workspace
  • fadc013 fix: recreate GITHUB_WORKSPACE with correct owner when deleted
  • cd652e0 fix: test build mount set to parent of current workspace
  • bb67daa Merge pull request #35 from easimon/fix/find-with-sudo
  • fe0431d fix: run free space reports with sudo as well
  • 557cb00 test: add test for root-owned build path
  • aed41c1 fix: run find with root permissions
  • 89c6c4b fix: remove duplicate mkdir
  • 69e8e45 Merge pull request #33 from easimon/fix/allow-removal-of-workspace-directory
  • 62d379b feat: show directory contents of build mount path if not empty
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [easimon/maximize-build-space](https://github.com/easimon/maximize-build-space) from 8 to 10.
- [Release notes](https://github.com/easimon/maximize-build-space/releases)
- [Changelog](https://github.com/easimon/maximize-build-space/blob/master/CHANGELOG.md)
- [Commits](easimon/maximize-build-space@09ba4bd...fc881a6)

---
updated-dependencies:
- dependency-name: easimon/maximize-build-space
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added kind/dependency-change Categorizes issue or PR as related to changing dependencies release-note-none Label for when a PR does not need a release note labels Mar 4, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2024
@openshift-ci openshift-ci bot requested review from HeavyWombat and otaviof March 4, 2024 13:02
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 4, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
Copy link
Contributor

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6fd95ce into main Mar 4, 2024
14 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the dependabot/github_actions/easimon/maximize-build-space-10 branch March 4, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant