Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure curl cmd follows redirection #1536

Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented Mar 11, 2024

Changes

Ensure curl cmd follows redirection.

The current state gives no value, when using curl, therefore installing something will fail.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 11, 2024
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Label for when a PR does not need a release note labels Mar 11, 2024
@qu1queee qu1queee added kind/documentation Categorizes issue or PR as related to documentation. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Label for when a PR does not need a release note labels Mar 11, 2024
@qu1queee qu1queee marked this pull request as ready for review March 11, 2024 10:50
@openshift-ci openshift-ci bot requested a review from HeavyWombat March 11, 2024 10:50
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Mar 11, 2024
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 12, 2024
Copy link
Contributor

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9c5300d into shipwright-io:main Mar 12, 2024
13 checks passed
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.13.0 milestone Mar 12, 2024
@qu1queee qu1queee deleted the qu1queee/readme_curl_nightly branch March 12, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants