Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set dockerfile parameter to an empty string to align with behavior of alpha controller #1569

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Do not set dockerfile parameter to an empty string to align with behavior of alpha controller #1569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/apis/build/v1beta1/build_conversion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ func (dest *BuildSpec) ConvertFrom(orig *v1alpha1.BuildSpec) error {
}

//handle spec.Dockerfile migration
if orig.Dockerfile != nil {
if orig.Dockerfile != nil && *orig.Dockerfile != "" {
dockerfileParam := ParamValue{
Name: "dockerfile",
SingleValue: &SingleValue{
Expand Down