Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit image tags in BuildAh sample build strategy #1600

Merged
merged 2 commits into from
May 14, 2024
Merged

Revisit image tags in BuildAh sample build strategy #1600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2692f43
Filter out BuildAh immutable tags
SaschaSchwarze0 May 12, 2024
fe5ffc7
Change imagePullPolicy to Always so that the newest BuildAh image is …
SaschaSchwarze0 May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/check-latest-images.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ function update() {
# Determine the latest tag
QUERY=".tag_name"
if [[ ${IMAGE} == *buildah* ]]; then
QUERY=".tags | sort_by(.name) | reverse | .[0].name"
QUERY="[.tags[] | select(.name | endswith(\"immutable\") | not) ] | sort_by(.name) | reverse | .[0].name"
fi
LATEST_TAG="$(curl --silent --retry 3 "${LATEST_RELEASE_URL}" | jq --raw-output "${QUERY}")"

Expand Down
1 change: 1 addition & 0 deletions samples/v1alpha1/buildstrategy/buildah/buildstrategy_buildah_shipwright_managed_push_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ spec:
buildSteps:
- name: build
image: quay.io/containers/buildah:v1.35.3
imagePullPolicy: Always
workingDir: $(params.shp-source-root)
securityContext:
privileged: true
Expand Down
1 change: 1 addition & 0 deletions samples/v1alpha1/buildstrategy/buildah/buildstrategy_buildah_strategy_managed_push_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ spec:
buildSteps:
- name: build-and-push
image: quay.io/containers/buildah:v1.35.3
imagePullPolicy: Always
workingDir: $(params.shp-source-root)
securityContext:
capabilities:
Expand Down
1 change: 1 addition & 0 deletions samples/v1alpha1/buildstrategy/source-to-image/buildstrategy_source-to-image-redhat_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ spec:
mountPath: /s2i
- name: buildah
image: quay.io/containers/buildah:v1.35.3
imagePullPolicy: Always
workingDir: /s2i
securityContext:
privileged: true
Expand Down
1 change: 1 addition & 0 deletions samples/v1beta1/buildstrategy/buildah/buildstrategy_buildah_shipwright_managed_push_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ spec:
steps:
- name: build
image: quay.io/containers/buildah:v1.35.3
imagePullPolicy: Always
workingDir: $(params.shp-source-root)
securityContext:
privileged: true
Expand Down
1 change: 1 addition & 0 deletions samples/v1beta1/buildstrategy/buildah/buildstrategy_buildah_strategy_managed_push_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ spec:
steps:
- name: build-and-push
image: quay.io/containers/buildah:v1.35.3
imagePullPolicy: Always
workingDir: $(params.shp-source-root)
securityContext:
capabilities:
Expand Down
1 change: 1 addition & 0 deletions samples/v1beta1/buildstrategy/source-to-image/buildstrategy_source-to-image-redhat_cr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ spec:
mountPath: /s2i
- name: buildah
image: quay.io/containers/buildah:v1.35.3
imagePullPolicy: Always
workingDir: /s2i
securityContext:
capabilities:
Expand Down