Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Owners #1608

Merged

Conversation

qu1queee
Copy link
Contributor

@qu1queee qu1queee commented May 23, 2024

Changes

Move out @otaviof to Emeritus
Add @apoorvajagtap to approvers and reviewers.
Add @karanibm6 to approvers

Congrats @apoorvajagtap and @karanibm6 !

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2024
@openshift-ci openshift-ci bot added release-note-none Label for when a PR does not need a release note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 23, 2024
@qu1queee qu1queee force-pushed the qu1queee/ownersfile_updates branch 2 times, most recently from 56c077e to e7cbc95 Compare May 23, 2024 09:46
@qu1queee qu1queee marked this pull request as ready for review May 23, 2024 09:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
@qu1queee qu1queee requested a review from otaviof May 23, 2024 09:47
@qu1queee qu1queee force-pushed the qu1queee/ownersfile_updates branch from e7cbc95 to 94f1d87 Compare May 23, 2024 09:49
@qu1queee qu1queee added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label May 23, 2024
@qu1queee qu1queee requested a review from HeavyWombat May 23, 2024 09:52
@HeavyWombat
Copy link
Contributor

Do we have any documentation on the emeritus_ prefix? I cannot find anything in https://www.kubernetes.dev/docs/guide/owners/ other than emeritus_approvers.

@qu1queee
Copy link
Contributor Author

@HeavyWombat this follows what we have in CLI, it does not affect anything. If we stick to the guidelines then what we need to do is simply remove reviewers, per:

If the person is in reviewers section, their GitHub id will be removed from the section

I prefer to have the reviewers emeritus.

@SaschaSchwarze0
Copy link
Member

@HeavyWombat this follows what we have in CLI, it does not affect anything. If we stick to the guidelines then what we need to do is simply remove reviewers, per:

If the person is in reviewers section, their GitHub id will be removed from the section

I prefer to have the reviewers emeritus.

I think we need to doublecheck at least.

I remember a discussion in a community meeting where we had the same and I think @adambkaplan clarified that unfortunatly, there are no emeritus reviewers. Should the (unknown) field be ignored by whatever tool that is reading this file, then fine with me. But we should rule out that it breaks something.

Move out Otavio to Emeritus
Add Apoorva to approver and reviewers
Add Karan to reviewers
@qu1queee qu1queee force-pushed the qu1queee/ownersfile_updates branch from 94f1d87 to 680a2a4 Compare June 12, 2024 12:19
@qu1queee qu1queee removed the request for review from otaviof June 12, 2024 12:19
@qu1queee
Copy link
Contributor Author

I removed the emeritus_reviewer, can I get a review pls @SaschaSchwarze0 @adambkaplan ?

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
Copy link
Contributor

@HeavyWombat HeavyWombat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HeavyWombat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4d595f6 into shipwright-io:main Jun 14, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants