-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Owners #1608
Updates to Owners #1608
Conversation
56c077e
to
e7cbc95
Compare
e7cbc95
to
94f1d87
Compare
Do we have any documentation on the |
@HeavyWombat this follows what we have in CLI, it does not affect anything. If we stick to the guidelines then what we need to do is simply remove reviewers, per:
I prefer to have the reviewers emeritus. |
I think we need to doublecheck at least. I remember a discussion in a community meeting where we had the same and I think @adambkaplan clarified that unfortunatly, there are no emeritus reviewers. Should the (unknown) field be ignored by whatever tool that is reading this file, then fine with me. But we should rule out that it breaks something. |
Move out Otavio to Emeritus Add Apoorva to approver and reviewers Add Karan to reviewers
94f1d87
to
680a2a4
Compare
I removed the emeritus_reviewer, can I get a review pls @SaschaSchwarze0 @adambkaplan ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
Move out @otaviof to Emeritus
Add @apoorvajagtap to approvers and reviewers.
Add @karanibm6 to approvers
Congrats @apoorvajagtap and @karanibm6 !
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes