Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Tekton #1671

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
3 changes: 3 additions & 0 deletions .github/bump-tekton-lts.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#!/usr/bin/env bash
# Copyright The Shipwright Contributors
#
# SPDX-License-Identifier: Apache-2.0

set -euo pipefail

Expand Down
34 changes: 21 additions & 13 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true
- name: Install Trivy
Expand Down Expand Up @@ -63,13 +63,13 @@ jobs:
fail-fast: false
matrix:
kubernetes:
- v1.27.11
- v1.29.2
- v1.28.13
- v1.31.0
tekton:
# oldest LTS that exists at the time of our planned next release
- v0.53.5
# newest LTS that exists at the time of our planned next release
- v0.59.2 # RETAIN-COMMENT: TEKTON_NEWEST_LTS
- v0.62.3 # RETAIN-COMMENT: TEKTON_NEWEST_LTS
max-parallel: 4
runs-on: ubuntu-latest
steps:
Expand All @@ -78,7 +78,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true
- name: Install Ko
Expand Down Expand Up @@ -120,8 +120,12 @@ jobs:
TEKTON_VERSION: ${{ matrix.tekton }}
run: |
make kind-tekton
kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-controller --timeout=1m
kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-webhook --timeout=1m
if ! kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-controller --timeout=3m; then
echo "[ERROR] Tekton installation did not complete. Debug info:"
kubectl -n tekton-pipelines get pod -o wide
exit 1
fi
kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-webhook --timeout=3m
- name: Test
run: |
# host.docker.internal does not work in a GitHub action
Expand All @@ -139,13 +143,13 @@ jobs:
fail-fast: false
matrix:
kubernetes:
- v1.27.11
- v1.29.2
- v1.28.13
- v1.31.0
tekton:
# oldest LTS that exists at the time of our planned next release
- v0.53.5
# newest LTS that exists at the time of our planned next release
- v0.59.2 # RETAIN-COMMENT: TEKTON_NEWEST_LTS
- v0.62.3 # RETAIN-COMMENT: TEKTON_NEWEST_LTS
max-parallel: 4
runs-on: ubuntu-latest
steps:
Expand All @@ -164,7 +168,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true
- name: Install kubectl
Expand Down Expand Up @@ -203,8 +207,12 @@ jobs:
TEKTON_VERSION: ${{ matrix.tekton }}
run: |
make kind-tekton
kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-controller --timeout=1m
kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-webhook --timeout=1m
if ! kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-controller --timeout=3m; then
echo "[ERROR] Tekton installation did not complete. Debug info:"
kubectl -n tekton-pipelines get pod -o wide
exit 1
fi
kubectl -n tekton-pipelines rollout status deployment tekton-pipelines-webhook --timeout=3m
- name: Install Registry
run: |
kubectl apply -f test/data/registry.yaml
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/mirror-images.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
library/golang:1.19 \
library/golang:1.20 \
library/golang:1.21 \
library/golang:1.22 \
library/maven:3-jdk-8-openj9 \
library/node:12 \
library/node:14 \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
fetch-depth: 0 # Fetch all history, needed for release note generation.
- uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-tekton-version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/verify.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: '1.21.x'
go-version: '1.22.x'
cache: true
check-latest: true
cache-dependency-path: go/src/github.com/shipwright-io/build
Expand Down
2 changes: 1 addition & 1 deletion HACK.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ In the near future, the above would be setup by the controller.
make clean && make build
```

* This project uses Golang 1.21 and controller-gen v0.12.1.
* This project uses Golang 1.22 and controller-gen v0.14.0.
* The controllers create/watch Tekton objects.

# Testing
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ ZAP_FLAGS ?= --zap-log-level=debug --zap-encoder=console
TEST_NAMESPACE ?= default

# CI: tekton pipelines controller version
TEKTON_VERSION ?= v0.50.5
TEKTON_VERSION ?= v0.62.3

# E2E test flags
TEST_E2E_FLAGS ?= -r -p --randomize-all -timeout=1h -trace -v
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Shipwright supports any tool that can build container images in Kubernetes clust
- We also require a Tekton installation (v0.50.+). To install the latest LTS release, run:

```bash
kubectl apply --filename https://storage.googleapis.com/tekton-releases/pipeline/previous/v0.50.5/release.yaml
kubectl apply --filename https://storage.googleapis.com/tekton-releases/pipeline/previous/v0.62.3/release.yaml
```

If you are using OpenShift cluster refer [Running on OpenShift](#running-on-openshift) for some more configurations.
Expand Down
8 changes: 5 additions & 3 deletions cmd/shipwright-build-controller/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
"sigs.k8s.io/controller-runtime/pkg/client/config"
"sigs.k8s.io/controller-runtime/pkg/manager"
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
"sigs.k8s.io/controller-runtime/pkg/metrics/server"

buildconfig "github.com/shipwright-io/build/pkg/config"
"github.com/shipwright-io/build/pkg/controller"
Expand Down Expand Up @@ -90,8 +91,9 @@ func main() {
LeaseDuration: buildCfg.ManagerOptions.LeaseDuration,
RenewDeadline: buildCfg.ManagerOptions.RenewDeadline,
RetryPeriod: buildCfg.ManagerOptions.RetryPeriod,
Namespace: "",
MetricsBindAddress: fmt.Sprintf("%s:%d", metricsHost, metricsPort),
Metrics: server.Options{
BindAddress: fmt.Sprintf("%s:%d", metricsHost, metricsPort),
},
})
if err != nil {
ctxlog.Error(ctx, err, "")
Expand Down Expand Up @@ -122,7 +124,7 @@ func main() {
// Add optionally configured extra handlers to metrics endpoint
for path, handler := range buildMetrics.ExtraHandlers() {
ctxlog.Info(ctx, "Adding metrics extra handler path", "path", path)
if err := mgr.AddMetricsExtraHandler(path, handler); err != nil {
if err := mgr.AddMetricsServerExtraHandler(path, handler); err != nil {
ctxlog.Error(ctx, err, "")
os.Exit(2)
}
Expand Down
Loading