Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --vv and --trace in E2E #1708

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Use --vv and --trace in E2E #1708

merged 1 commit into from
Oct 30, 2024

Conversation

HeavyWombat
Copy link
Contributor

@HeavyWombat HeavyWombat commented Oct 30, 2024

Changes

Based on the documentation, increase verbosity to improve the ability to debug issues based on the Ginkgo output:

  --vv
    If set, emits with maximal verbosity - includes skipped and pending tests.

  --trace
    If set, default reporter prints out the full stack trace when a failure
    occurs

This should help us to address the panic in the AfterEach for example here that blocks us to determine why the test case actually faliled:

2024-10-30T12:09:48Z 1 Still waiting for build run 'timestamp-lm5jx' to succeed.
  2024-10-30T12:10:48Z 1 Still waiting for build run 'timestamp-lm5jx' to succeed.
  [FAILED] in [It] - /home/runner/work/build/build/test/e2e/v1beta1/validators_test.go:134 @ 10/30/24 12:11:08.558
  2024-10-30T12:11:08Z 1 Print failed BuildRun's log
  [PANICKED] in [AfterEach] - /opt/hostedtoolcache/go/1.22.8/x64/src/runtime/panic.go:261 @ 10/30/24 12:11:08.561
  << Timeline

  [FAILED] BuildRun status doesn't move to Succeeded
  Expected
      <v1.ConditionStatus>: False
  not to equal
      <v1.ConditionStatus>: False
  In [It] at: /home/runner/work/build/build/test/e2e/v1beta1/validators_test.go:134 @ 10/30/24 12:11:08.558

  Full Stack Trace
    github.com/shipwright-io/build/test/e2e/v1beta1_test.validateBuildRunToSucceed.func1()
    	/home/runner/work/build/build/test/e2e/v1beta1/validators_test.go:134 +0x3d5
    reflect.Value.call({0x1c3d0e0?, 0xc0008e8150?, 0xc00006dbf8?}, {0x20037cc, 0x4}, {0x35254a0, 0x0, 0xc00006dc4a?})
    	/opt/hostedtoolcache/go/1.22.8/x64/src/reflect/value.go:596 +0xca6
    reflect.Value.Call({0x1c3d0e0?, 0xc0008e8150?, 0x20?}, {0x35254a0?, 0x1?, 0x3?})
    	/opt/hostedtoolcache/go/1.22.8/x64/src/reflect/value.go:380 +0xb9
    github.com/onsi/gomega/internal.(*AsyncAssertion).buildActualPoller.func3()
    	/home/runner/work/build/build/vendor/github.com/onsi/gomega/internal/async_assertion.go:325 +0x11f
    github.com/onsi/gomega/internal.(*AsyncAssertion).match(0xc00039ab60, {0x234ba60, 0xc0009a5cb0}, 0x1, {0xc0009a5cc0, 0x1, 0x1})
    	/home/runner/work/build/build/vendor/github.com/onsi/gomega/internal/async_assertion.go:548 +0x7cc
    github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0xc00039ab60, {0x234ba60, 0xc0009a5cb0}, {0xc0009a5cc0, 0x1, 0x1})
    	/home/runner/work/build/build/vendor/github.com/onsi/gomega/internal/async_assertion.go:145 +0x86
    github.com/shipwright-io/build/test/e2e/v1beta1_test.validateBuildRunToSucceed(0xc0002d8af0, 0xc0000f5000)
    	/home/runner/work/build/build/test/e2e/v1beta1/validators_test.go:144 +0x342
    github.com/shipwright-io/build/test/e2e/v1beta1_test.init.func1.6.4.4()
    	/home/runner/work/build/build/test/e2e/v1beta1/e2e_image_mutate_test.go:202 +0x47

  There were additional failures detected.  To view them in detail run ginkgo -vv

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Based on the documenation, increase verbosity to improve the ability to
debug issues based on the Ginkgo output:

  --vv
    If set, emits with maximal verbosity - includes skipped and pending tests.

  --trace
    If set, default reporter prints out the full stack trace when a failure
    occurs

Signed-off-by: Matthias Diester <[email protected]>
@HeavyWombat HeavyWombat added the kind/flake Categorizes issue or PR as related to a flaky test. label Oct 30, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Oct 30, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Oct 30, 2024
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2024
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2024
@SaschaSchwarze0 SaschaSchwarze0 merged commit 564718b into main Oct 30, 2024
19 of 22 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the increase/verbosity branch October 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants