Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add total size and total file count to file listing #1721

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

HeavyWombat
Copy link
Contributor

Changes

Follow-up from #1702 to add the total size in bytes of all files and the total number of files to the file listing so that its immediately visible.

$ bundle --image ghcr.io/shipwright-io/sample-go/source-bundle:latest --target /tmp/workspace/source --show-listing
2024/11/04 11:58:04 Pulling image "ghcr.io/shipwright-io/sample-go/source-bundle:latest"
2024/11/04 11:58:05 Image content was extracted to /tmp/workspace/source
 -rw-r--r--  1  501  0  11.1K  LICENSE
 -rw-r--r--  1  501  0   249B  OWNERS
 -rw-r--r--  1  501  0   1.3K  README.md
 drwxr-xr-x  4  501  0   128B  docker-build
 -rw-r--r--  1  501  0   381B  docker-build/Dockerfile
 -rw-r--r--  1  501  0   972B  docker-build/main.go
 drwxr-xr-x  4  501  0   128B  docker-build-with-args
 -rw-r--r--  1  501  0   528B  docker-build-with-args/Dockerfile
 -rw-r--r--  1  501  0   972B  docker-build-with-args/main.go
 drwxr-xr-x  4  501  0   128B  source-build
 -rw-r--r--  1  501  0    35B  source-build/go.mod
 -rw-r--r--  1  501  0   972B  source-build/main.go
 drwxr-xr-x  4  501  0   128B  source-build-with-package
 -rw-r--r--  1  501  0    35B  source-build-with-package/go.mod
 drwxr-xr-x  3  501  0    96B  source-build-with-package/main-package
 -rw-r--r--  1  501  0   972B  source-build-with-package/main-package/main.go
──────────────────────────────────────────────────────────────────────────────
                          18K  16 files

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

Follow-up from #1702 to add the
total size in bytes of all files and the total number of files to the file
listing so that its immediately visible.

Signed-off-by: Matthias Diester <[email protected]>
@HeavyWombat HeavyWombat added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 4, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Nov 4, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 4, 2024
@HeavyWombat HeavyWombat marked this pull request as draft November 4, 2024 11:05
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@HeavyWombat HeavyWombat marked this pull request as ready for review November 4, 2024 11:12
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 4, 2024
@HeavyWombat HeavyWombat requested review from SaschaSchwarze0 and removed request for apoorvajagtap November 4, 2024 11:12
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2024
Copy link
Contributor

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.14.0 milestone Nov 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit bc67868 into main Nov 4, 2024
22 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the tweak/file-listing branch November 4, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants