Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Go 1.23 to the list of mirrors #1741

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add Go 1.23 to the list of mirrors #1741

merged 1 commit into from
Nov 29, 2024

Conversation

HeavyWombat
Copy link
Contributor

Changes

Add golang:1.23 to the mirror list.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

NONE

@HeavyWombat HeavyWombat added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 29, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 29, 2024
@openshift-ci openshift-ci bot added the release-note-none Label for when a PR does not need a release note label Nov 29, 2024
@HeavyWombat
Add Go 1.23 to the list of mirrors
5c7bb32 
Add `golang:1.23` to the mirror list.

Signed-off-by: Matthias Diester <[email protected]>
SaschaSchwarze0
SaschaSchwarze0 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SaschaSchwarze0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2024
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Nov 29, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6a257c0 into main Nov 29, 2024
21 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the add/go-1.23-mirror branch November 29, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaschaSchwarze0 SaschaSchwarze0 SaschaSchwarze0 approved these changes

@karanibm6 karanibm6 Awaiting requested review from karanibm6

Assignees

@SaschaSchwarze0 SaschaSchwarze0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Label for when a PR does not need a release note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HeavyWombat @SaschaSchwarze0