SHIP-0003: Tekton Custom Task

[imjasonh]

cc @sbose78 @adambkaplan @qu1queee

[adambkaplan]

/approve

This is a good provisional proposal. My comments are meant for general discussion or items to consider when we get to the implementable phase.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbose78]

Looks good, would be nice to have a sample tekton pipeline yaml included in the proposal. :)

[SaschaSchwarze0]

I would like to make sure we make this feature meet the user's use cases. So, from a user's perspective, one might be missing certain features to integrate a Run which is a BuildRun into a larger Tekton pipeline:

• passing the source through a Tekton workspace; or at least overwriting the source (like the revision) of the build through the Pipeline
• getting insights into the image that was built (the image sha or the full image URL)

All these things require features in the build controller, but for the e2e story = to build a reasonable Tekton pipeline that does something useful, I think it will be necessary to speak out these things already.

[qu1queee]

@imjasonh sorry for the late reply in here. I would like this SHP to consider more aspects around the integration for:

• Tekton Triggers
• An embedded SHP in Tekton Pipeline resources

I do not have the whole picture yet clear, but I wrote some key points we might wanna consider, see delta. I can open a proper PR to yours if you want, or you can consume some of the ideas I wrote there. Let me know.

[imjasonh]

Hi @qu1queee @SaschaSchwarze0 sorry for the very late reply. 😓

I agree there's probably more design work to be done to think through how this integrates with a Tekton Pipeline, especially the areas you've highlighted around reusing Tekton's workspaces, and emitting results to downstream Tasks. I believe with changes like #13 we can have the Custom Task controller adapt Shipwright Build .status.results (incl git SHA and image SHA) to Tekton .status.results, and with the evolving work around sources we can find some way to adapt workspaces to an input source.

Ultimately this is a provisional SHIP, so I don't think we need to answer all of these questions definitively before merging it. We can layer on more design considerations and features before it becomes implementable.

[adambkaplan]

@imjasonh since we merged the previous enhancement proposals here, please update the title and numbering to SHIP-0020

[qu1queee]

@imjasonh moving out of this PR as I would not be able to provide feedback in the next weeks. @SaschaSchwarze0 fyi.

[SaschaSchwarze0]

We are closing the SHIP as it is being included in https://github.com/shipwright-io/community/blob/main/ships/0031-shipwright-trigger.md