Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: Fix broken link to build controller deployment YAML manifest #47

Conversation

timflannagan
Copy link
Contributor

Update the configuration.md documentation and fix the broken link to the
build controller deployment YAML manifest.

Update the configuration.md documentation and fix the broken link to the
build controller deployment YAML manifest.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign adambkaplan after the PR has been reviewed.
You can assign the PR to them by writing /assign @adambkaplan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@timflannagan
Copy link
Contributor Author

Found another one going through the docs 😆

I pointed the link to the latest tag vs. the main branch to help cut down on broken links in the future.

@timflannagan
Copy link
Contributor Author

Might be worth adding a CI check that lints PRs (e.g. https://github.com/operator-framework/olm-docs/blob/master/hack/ci/link-check.sh). I can open an issue tracking that if you're interested.

@timflannagan
Copy link
Contributor Author

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@timflannagan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@SaschaSchwarze0
Copy link
Member

Hi @timflannagan, sry for having missed this. I am not sure if we here want to point to the latest version or main. Kind of related to the doc synchronization where Adam has looked in.

/assign adambkaplan

@timflannagan
Copy link
Contributor Author

Trying to clear my open PRs so I'm going to close this out as it's been sitting for a while and open an issue instead: #52.

@timflannagan timflannagan deleted the fix-controller-config-link branch September 15, 2021 03:57
@timflannagan timflannagan restored the fix-controller-config-link branch September 15, 2021 03:57
@timflannagan timflannagan deleted the fix-controller-config-link branch September 15, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants