-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proofreading build.md #58 #59
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b785eb2
to
8e1f45b
Compare
3e26e9c
to
bcea97c
Compare
@gabemontero @HeavyWombat What do you think about these copy edits? |
Hi @rolfedh, thank you for engaging in the documents. Many of them are actually only a copy here. May you primarily update the original files under https://github.com/shipwright-io/build/tree/main/docs ? The sync itself is unfortunately a manual actions still. :-( But your changes would come after #54. |
@rolfedh: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I really appreciate the help with this level of detail.
/lgtm
Thanks @SaschaSchwarze0 @HeavyWombat. I might try to update https://github.com/shipwright-io/build/tree/main/docs instead. |
While reading the docs, I made a few proofreading copy edits. This fixes #58.