Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[permissions] move permissions to database, add GUI permissions editor #1149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

discomrade
Copy link
Contributor

@discomrade discomrade commented May 8, 2024

Closes #1139

This does not handle existing user-defined classes (e.g. data/config/user-classes.conf.php) so I suggest the next release mention that users should remove from any custom user classes before upgrading.

This pull also implies changes to the wiki: https://github.com/shish/shimmie2/wiki/Advanced-Config

@discomrade discomrade force-pushed the permissions branch 3 times, most recently from 2eeb314 to 486816b Compare May 8, 2024 06:24
@shish
Copy link
Owner

shish commented Feb 21, 2025

So this PR has been haunting me for months because I've wanted to get it merged, but something has felt off, but I wasn't able to say what -- turns out my worries were nearly all in my own code that this builds on top of 😆 So now that I've gone and redone how permissions are defined (putting them in per-extension files, rather than one central list), I'm now working on merging this on top of that /o/

One noteworthy change being that I'm thinking of making the permissions table more like permissions(user_class, permission_id, allowed) rather than having a separate column-per-permission -- the new foundations allow for adding and removing permissions when extensions are enabled or disabled, and doing a database schema change in each case sounds scary >.>;;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GUI Permission Editor
2 participants