-
Notifications
You must be signed in to change notification settings - Fork 7
feature: Add relationship between core entities to make it persistable in database #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
- Coverage 72.42% 69.28% -3.15%
==========================================
Files 16 33 +17
Lines 2473 3086 +613
==========================================
+ Hits 1791 2138 +347
- Misses 639 872 +233
- Partials 43 76 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 59 out of 60 changed files in this pull request and generated no comments.
Files not reviewed (1)
- sourcecode-parser/go.mod: Language not supported
Comments suppressed due to low confidence (3)
sourcecode-parser/cmd/query.go:161
- The refactored header output now uses 'MethodDecl.SourceDeclaration' and 'MethodDecl.ID' instead of the previously used file and line number fields. Please verify that these fields consistently represent the desired information across all entity types.
header := fmt.Sprintf(" File: %s, Line: %s \n", greenCode(entity.MethodDecl.SourceDeclaration), greenCode(entity.MethodDecl.ID))
sourcecode-parser/antlr/listener_impl.go:246
- The logic for building the expression tree in ExitEqualityExpression assumes that exactly three stack elements are available for a binary operation. Please double-check that this condition properly handles all valid cases in the grammar.
if len(l.currentExpression) >= 3 {
sourcecode-parser/antlr/listener_impl.go:370
- When initializing the currentExpression stack for the root WHERE clause in EnterExpression, ensure that this reset does not inadvertently discard any necessary state from nested expressions.
l.currentExpression = make([]*ExpressionNode, 0)
Description:
This PR adds relationship between the entities which should help to store them in relational format. Creating relationship between the entities reduces drastically search space to filter nodes while
codeql
query is executed. Further more adopting #190 class support further drives to implement class and filters by the end users to reduce the search space.cartesian product
and waste memory and computing time. We could warn the user by checking the cardinality of the dataset before filtering or generating cartesian product and let the user decide to run the query.Checklist:
gradle testGo
)?golangci-lint run
this requires golangci-lint)?