Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash set RTMPConneciton.timeout. #1360

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix crash set RTMPConneciton.timeout. #1360

merged 1 commit into from
Dec 18, 2023

Conversation

shogo4405
Copy link
Owner

@shogo4405 shogo4405 commented Dec 18, 2023 •
edited
Loading

Description & motivation

I have fixed the issue where the value of connection.timeout could not be set as expected in the instance's state.

let conneciton = RTMPConnection()
conneciton.timeout = 5

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots:

スクリーンショット 2023-12-18 20 09 19

@shogo4405 shogo4405 changed the title make optional RTMPConenciton.socket property. Fix crash set RTMPConneciton.timeout. Dec 18, 2023
@shogo4405 shogo4405 added this to the 1.7.3 milestone Dec 18, 2023
@shogo4405 shogo4405 marked this pull request as ready for review December 18, 2023 12:45
@shogo4405 shogo4405 mentioned this pull request Dec 18, 2023
Closed
1 task
@shogo4405 shogo4405 merged commit 5cfdb7b into main Dec 18, 2023
1 check passed
@shogo4405 shogo4405 deleted the feature/timeout branch December 18, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.3
Development

Successfully merging this pull request may close these issues.
1 participant
@shogo4405