Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releaseStream command call #1389

Closed
wants to merge 1 commit into from

Conversation

levs42
Copy link
Contributor

@levs42 levs42 commented Mar 15, 2024

Description & motivation

This PR adds a releaseStream call that is used to release a published stream with the same name. This feature is undocumented but commonly used. For example, OBS sends it before FCPublish. I thought to expose some interface so HK users could send it manually, however 1. HK already has undocumented FCPublish/FCUnpublish 2. When releaseStream isn't supported, the server will ignore it.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

@levs42
Copy link
Contributor Author

levs42 commented Mar 15, 2024

Looks like both OBS and ffmpeg (line 601) call releaseStream and FCPublish before createStream. Right now FCPublish is called after createStream. Should we move it?

@shogo4405
Copy link
Owner

I cannot accept this because it references GPL source code. This decision is made to protect the businesses of HaishinKit users.

OBS is under the GPL license, and ffmpeg is under the LGPL license. Understanding that writing code while looking at these sources requires (L)GPL compliance.

Furthermore, it's understood that the AppStore is incompatible with GPL. In order to ensure everyone can conduct business on the AppStore with peace of mind, I maintain the BSD license for HaishinKit development. I develop HaishinKit without looking at the code of OBS or ffmpeg.

@shogo4405 shogo4405 closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants