Added validation at the start of recording.

[shogo4405]

Description & motivation

• Added validation when a file is specified at the start of recording. An exception will be thrown if the file already exists.
  • fix: handling existing file when starting recording #1611

Type of change

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots:

[vkornel97]

This should be outputURL.path.

[vkornel97]

If you pass an URL that represents a file without a path extension (e.g. file:///var/mobile/Containers/Data/Application/7910F2B5-9C52-42CE-87D0-20202839EB58/Documents/Demo ) this logic would result in something like this: file:///var/mobile/Containers/Data/Application/7910F2B5-9C52-42CE-87D0-20202839EB58/Documents/file:///var/mobile/Containers/Data/Application/7910F2B5-9C52-42CE-87D0-20202839EB58/Documents/Demo.mp4, which is an incorrect file path.

A more future-proof suggestion to the file parameter and the outputURL handling:

    if let file {
          if file.hasDirectoryPath {
              outputURL = file.appendingPathComponent(UUID().uuidString)
          } else {
              outputURL = file
          }
          if outputURL.pathExtension == "" {
              outputURL = outputURL.appendingPathExtension(Self.defaultPathExtension)
          }
      } else {
          outputURL = moviesDirectory.appendingPathComponent(UUID().uuidString).appendingPathExtension(Self.defaultPathExtension)
      }

Tested with:

• URL representing a directory.
• URL representing a file without extension
• URL representing a file with extension
• nil URL

[shogo4405]

Thank you for testing it. I’ve also added some test cases on my end. I’m thinking of adding the documentation and then merging.