Skip to content

docs: Add docs for response headers in app scripts #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025

Conversation

keulinho
Copy link
Contributor

@keulinho keulinho self-assigned this Mar 28, 2025
@keulinho
Copy link
Contributor Author

@Isengo1989 running the spellcheck on the code reference seems not super helpful to me, what do we wanna do here? Add those words to the allowlist?

@Isengo1989
Copy link
Collaborator

@Isengo1989 running the spellcheck on the code reference seems not super helpful to me, what do we wanna do here? Add those words to the allowlist?

The two words are in a table and not wrapped by a code block.

image

The github action, however does catch some words sometimes from the code block. I guess when the fencing does not work properly.

In this case it's fine tho and I will add them.

@bojanrajh
Copy link
Collaborator

@Isengo1989 Healthcheck failed because of this PR, should be temporary fixed here.

@keulinho
Copy link
Contributor Author

keulinho commented Apr 3, 2025

Will update this when the feature is released and adjust the version where this was released

Copy link
Contributor

github-actions bot commented Apr 3, 2025

The feature is ready to be merged @Isengo1989 @sushmangupta @bojanrajh

@Isengo1989 Isengo1989 merged commit 4452055 into main Apr 17, 2025
6 of 7 checks passed
@Isengo1989 Isengo1989 deleted the add-app-script-response-header-docs branch April 17, 2025 07:25
Isengo1989 added a commit that referenced this pull request Apr 17, 2025
* test: workflow

* test: workflow

* test: workflow

* test: workflow

* test: workflow

* chore: sort .wordlist.txt

* test: workflow

* chore: sort .wordlist.txt

* test: workflow

* chore: test

* chore: sort .wordlist.txt

* Update .github/workflows/wordlist.yml

Co-authored-by: Bojan Rajh <[email protected]>

* chore: test-removed-step

* chore: sort .wordlist.txt

* docs: Add docs for response headers in app scripts (#1736)

* docs: Add docs for response headers in app scripts

* Fix lint and spelling issues

* chore: fix spellcheck

* Adjust release version

---------

Co-authored-by: Micha <[email protected]>

* test: redirect workflow (#1751)

* test: workflow

* test: workflow

* test: workflow comment

* Update .github/workflows/redirect.yml

Co-authored-by: Bojan Rajh <[email protected]>

* Update .github/workflows/redirect.yml

Co-authored-by: Bojan Rajh <[email protected]>

---------

Co-authored-by: Bojan Rajh <[email protected]>

* Reset .wordlist.txt to main branch version

* chore: sort .wordlist.txt

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bojan Rajh <[email protected]>
Co-authored-by: Jonas Elfering <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants