Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign #65

Merged
merged 291 commits into from
Dec 2, 2024
Merged

Redesign #65

merged 291 commits into from
Dec 2, 2024

Conversation

pka
Copy link
Member

@pka pka commented Sep 2, 2024 •
edited
Loading

I've changed the Hugo theme to Hextra and adapted it inspired by the Reveal solarized theme.

I hope you like it, @amandasaurus!

imfing added 30 commits August 18, 2023 23:18
@imfing
chore: update icon shortcode and partial
bb6b063
@imfing
chore: rename components to shortcodes
8298278
@imfing
feat: add mhchem support
57f2982
@imfing
chore: rename assets/vendor to lib
2e11d23
@imfing
feat: add more content and fix issues
1c79624 
fix: hide lang switch if site is not multilingual

docs: update getting started page

fix: ordered list style

chore: update hugo icon

feat: add icon shortcode page

docs: add markdown and configuration pages

docs: add diagrams page

docs: add more content

fix: mermaid background and add image styling

chore: update templates

chore: update hugo stats
@imfing
feat: implement collapsible sidebar
15d3a4d 
chore: basic sidebar toggle button
chore: update compiled css
@imfing
feat: support prev and next in frontmatter
228496f
@imfing
feat: add twtter cards to head
0360a93
@imfing
feat: navbar logo and title can be configured
80659b4 
chore: add logos to static and update compiled css
@imfing
feat: add subtitle and image support to card
b6f40d6
@imfing
chore: use max-w-screen-xl for content and footer
5f6b313
@imfing
chore: add image example for cards
aa13050 
* updated compiled CSS
@imfing
fix: translation for navbar menu
8073722 
docs: update docs for multi-language
chore: add custom css support
chore: add social icons
@imfing
ci: add pages.yml
600c8e5
@imfing
fix: remove configure pages
9b4113a
@imfing
fix: hugo build baseURL
7e302ac
@imfing
chore: update layouts
ce78845
@imfing
docs: add customization and update other pages
5821b02 
chore: re-compile css and add icons
chore: update blog list layout
@imfing
docs: update docs and footnote styles
86e5106
@imfing
docs: update index page
64e27cb 
fix(doc): icon file name
@imfing
feat: add rss template
04a5c73 
feat: enhance sidebar on mobile
chore: simplify settings by having defaults
chore: update footer template
@imfing
chore: update css height calc to use height var
4e250a4
@imfing
chore: remove taskfile
0db055d
@imfing
chore: update default list layout
d14091c
@imfing
chore: add displayPlaceholder option to sidebar
97f31e9
@imfing
fix: icon fill color should be current color
35dd9b8
@imfing
chore: add hextra home layout
7391788
@imfing
chore: update home page
d1bc057
@imfing
chore: update build configs
af77173
@imfing
fix: card links for getting started page
ede8991
pnorman
pnorman reviewed Sep 3, 2024
View reviewed changes
Copy link
Contributor

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process for upgrading to a new version of Hextra?

Is there a preview we could see, or at least a screenshot?

shortbread-website/content/_index.md Outdated Show resolved Hide resolved
@pka
Copy link
Member Author

pka commented Sep 4, 2024

screenshot-2024-09-04-07-25-05

screenshot-2024-09-04-07-24-21

On small screens, only one column is shown.

@pka
Copy link
Member Author

pka commented Sep 4, 2024

What's the process for upgrading to a new version of Hextra?

I'm maintaining a branch with the backport patches: https://github.com/pka/hextra/tree/backport-debian

Hugo docs recommend including a theme as git submodule. We could do that for simplifying updates. But not anybody likes working with submodules...

@pnorman
Copy link
Contributor

pnorman commented Sep 4, 2024

Hugo docs recommend including a theme as git submodule. We could do that for simplifying updates. But not anybody likes working with submodules...

A subtree is apparently easier to manage

@pka
Copy link
Member Author

pka commented Sep 4, 2024

In response to the overwelming enthusiasm, I've cleaned up the commits and added the hextra theme as subtree, to make it ready for merge.

@pka
Copy link
Member Author

pka commented Sep 4, 2024 •
edited
Loading

Oops, I just force-pushed accidently to main, will try to cleanup the mess...
It was just the main branch of my fork...

@joto
Copy link
Contributor

joto commented Sep 5, 2024

I don't understand why you need to backport a theme. It is just a bunch of CSS files and icons isn't it?

Anyway. Looks okay to me, certainly better than what we had before.

@pka
Copy link
Member Author

pka commented Sep 5, 2024

I don't understand why you need to backport a theme. It is just a bunch of CSS files and icons isn't it?

The theme uses built-in Hugo functions (hugo.IsMultiLingual and urls.JoinPath), which are not availabe in 0.111.

@pka
Copy link
Member Author

pka commented Sep 6, 2024

My plan was to have this ready for SotM. Does anyone plan a review, or is it ok to merge?

@pnorman pnorman self-requested a review September 8, 2024 03:46
@pka
Copy link
Member Author

pka commented Nov 1, 2024

I'll have a talk about Shortbread at FOSS4G in a month and would like to show the website in the new look. Would that be a motivation for reviewing and/or merging?

@joto
Copy link
Contributor

joto commented Nov 1, 2024

For my taste the condensed font is hard to read and the line-height leaves a lot of white-space. Other than that I am happy with the design. Its okay for me to go with this.

Something gets pulled in from gstatic.com, that should be fixed.

@pka
Copy link
Member Author

pka commented Nov 4, 2024

For my taste the condensed font is hard to read and the line-height leaves a lot of white-space. Other than that I am happy with the design. Its okay for me to go with this.

I see your point, but at least it makes Shortbread really short!

Something gets pulled in from gstatic.com, that should be fixed.

Fonts are now included.

joto
joto approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@joto joto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me.

pka added 7 commits December 2, 2024 14:25
@pka
Add 'shortbread-website/themes/hextra/' from commit 'ce3b99532a2b3127…
e5debcf 
…3852f76c6b4ee8376734a6a1'

git-subtree-dir: shortbread-website/themes/hextra
git-subtree-mainline: 0b30b97
git-subtree-split: ce3b995
@pka
Replace hugo-theme-docdock with hextra
9657223
@pka
Customize theme
7a650d3
@pka
Squashed 'shortbread-website/themes/hextra/' changes from ce3b995..ca…
f7addf2 
…444d9

ca444d9 Replace path.Join with printf

git-subtree-dir: shortbread-website/themes/hextra
git-subtree-split: ca444d974c56303bf772f9143651e3bcd2dd19da
@pka
Merge commit 'f7addf28caf18d0ad1d016aa74261c51e5aef15c' into HEAD
91628bd
@pka
Improve font styles for Chrome
8359af7
@pka
Self-host fonts
baa32c3
@pka pka merged commit 3d51532 into shortbread-tiles:main Dec 2, 2024
1 check passed
@pka pka deleted the theme branch December 2, 2024 13:28
@pka
Copy link
Member Author

pka commented Dec 2, 2024

Merged for FOSS4G for incorporating feedback during the conference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joto joto joto approved these changes

@pnorman pnorman Awaiting requested review from pnorman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.