SG-36346 Dynamic hard drive lookup in windows #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lang
reviewed
Dec 4, 2024
startup.py
Outdated
| # of the supported operating systems. The templates are used for both | ||
| # globbing and regex matches by replacing the named format placeholders | ||
| # with an appropriate glob or regex string. | ||
| self.EXECUTABLE_TEMPLATES = { |
There was a problem hiding this comment.
I'm not a big fan of overwritting the EXECUTABLE_TEMPLATES variable. Upper case variables are constants by conventions.
Could you instead create a new local variable and make sure it's used in the rest of the function?
eduardoChaucaGallegos
approved these changes
Dec 5, 2024
julien-lang
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing
win32api.GetLogicalDriveStrings()to get the list of available drive letters in Windows.In terms of performance,
win32api.GetLogicalDriveStrings()is generally very fast and efficient. It directly interfaces with the Windows API to get the list of logical drives, which is a relatively quick operation.Regarding the
globsearch, I've done lookup tests with a few different drive letters and it works with no major difference in performance.Testing
Install Alias software in a different drive than C:. SGD should be able to locate the software and add its icon normally.