fix: json output not using speed format #220
Conversation
speedtest/unit.go
Outdated
| @@ -45,17 +46,25 @@ type ByteRate float64 | |||
|
|
|||
| var globalByteRateUnit UnitType | |||
|
|
|||
| func (r ByteRate) MarshalJSON() ([]byte, error) { | |||
| if rStr := r.String(); rStr != naString { | |||
| return []byte(strings.Split(rStr, " ")[0]), nil | |||
There was a problem hiding this comment.
Since the unit is auto-scaled, the user cannot know what the unit is.
eg: when use speedtest.UnitTypeDecimalBits
the json output may be "bps", "Kbps", "Mbps" or "Gbps". This is hard to confirm.
There was a problem hiding this comment.
I see, I tried including the unit but it errors out, probably because it expects a float instead of a string, that's why I did the split to get rid of the unit. I could add a new field to the server struct for DLString and ULString, and make the original ones not appear in the JSON. I'll get an example to get your feedback.
|
Thank you very much @luevano, I left a comment. |
Thanks for the feedback, I changed the fix to add new fields and use those for the json, it now outputs as string value and contains the autoscaled value and the correct unit. Added example outputs in the OP. Closing reason: #219 (comment) |
Closes #219
Implemented Marshaler forAdded extra DL/UL fields toByteRate,Serverso that the json output uses the specified format and scaling for the speed values.Example output (string) (for default format/unit):
Example output (string) (for binary-bytes unit option):
Before output (float) (always the raw float value):